2012-05-03 00:02:13

by Hartley Sweeten

Subject: [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer

NULL not 0 should be used with pointers. Just remove the offending
lines since they will default to NULL anyway.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Evgeniy Polyakov <[email protected]>

---

diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c
index 7c8cdb8..8e813ee 100644
--- a/drivers/w1/slaves/w1_ds2408.c
+++ b/drivers/w1/slaves/w1_ds2408.c
@@ -332,7 +332,6 @@ static struct bin_attribute w1_f29_sysfs_bin_files[NB_SYSFS_BIN_FILES] = {
},
.size = 1,
.read = w1_f29_read_cond_search_mask,
- .write = 0,
},
{
.attr = {
@@ -341,7 +340,6 @@ static struct bin_attribute w1_f29_sysfs_bin_files[NB_SYSFS_BIN_FILES] = {
},
.size = 1,
.read = w1_f29_read_cond_search_polarity,
- .write = 0,
},
{
.attr = {

2012-05-03 18:02:05

by Evgeniy Polyakov

Subject: Re: [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer

On Wed, May 02, 2012 at 05:02:07PM -0700, H Hartley Sweeten ([email protected]) wrote:
> NULL not 0 should be used with pointers. Just remove the offending
> lines since they will default to NULL anyway.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Evgeniy Polyakov <[email protected]>

Looks good, thank you
Greg, please pull it into your tree or should it be forwarded to
janitor list?

--
Evgeniy Polyakov

2012-05-04 23:24:16

by Greg KH

Subject: Re: [PATCH] w1: w1_ds2408.c: quite sparse noise about using plaing integer as NULL pointer

On Thu, May 03, 2012 at 10:02:02PM +0400, Evgeniy Polyakov wrote:
> On Wed, May 02, 2012 at 05:02:07PM -0700, H Hartley Sweeten ([email protected]) wrote:
> > NULL not 0 should be used with pointers. Just remove the offending
> > lines since they will default to NULL anyway.
> >
> > Signed-off-by: H Hartley Sweeten <[email protected]>
> > Cc: Evgeniy Polyakov <[email protected]>
>
> Looks good, thank you
> Greg, please pull it into your tree or should it be forwarded to
> janitor list?

I'll take it, thanks.

greg k-h