2012-05-03 22:13:08

by Michael Davidson

Subject: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions

[PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions

DEVICE_INT_ATTR() should use device_show_int() and device_store_int()
not device_show_ulong() and device_store_ulong()

Signed-off-by: Michael Davidson <[email protected]>
---

--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -508,7 +508,7 @@ ssize_t device_store_int(struct device *
{ __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
#define DEVICE_INT_ATTR(_name, _mode, _var) struct dev_ext_attribute dev_attr_##_name = - { __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
+ { __ATTR(_name, _mode, device_show_int, device_store_int), &(_var) }

extern int device_create_file(struct device *device,
const struct device_attribute *entry);

2012-05-03 22:12:08

by Greg Kroah-Hartman

Subject: Re: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions

On Thu, May 03, 2012 at 03:07:47PM -0700, Michael Davidson wrote:
> [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions
>
> DEVICE_INT_ATTR() should use device_show_int() and device_store_int()
> not device_show_ulong() and device_store_ulong()
>
> Signed-off-by: Michael Davidson <[email protected]>
> ---
>
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -508,7 +508,7 @@ ssize_t device_store_int(struct device *
> { __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
> #define DEVICE_INT_ATTR(_name, _mode, _var) struct dev_ext_attribute dev_attr_##_name = - { __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
> + { __ATTR(_name, _mode, device_show_int, device_store_int), &(_var) }

Something odd happened with your patch, and I can't apply it :(

Care to try again?