2012-05-05 10:50:36

by Anton Vorontsov

[permalink] [raw]
Subject: Re: [PATCH 0/6] twl4030: Various fixes for charing-from-USB

On Mon, Apr 30, 2012 at 09:30:02AM +1000, NeilBrown wrote:
> > > Following are a collection of patches that I've need using for a while
> > > to make sure the charge-from-usb on my GTA04 works.
> > > Hopefully I've included the right people in the recipient list :-)
> >
> > You missed the power supply maintainers - ./scripts/get_maintainer.pl
> > is usually good at finding the right people, although their
> > MAINTAINERS entry could be better I guess..
> >
> >
>
> I guess you mean:
>
> POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
> M: Anton Vorontsov <[email protected]>
> M: David Woodhouse <[email protected]>
> T: git git://git.infradead.org/battery-2.6.git
> S: Maintained
> F: include/linux/power_supply.h
> F: drivers/power/power_supply*
>
>
> get_maintainer.pl didn't find them. The F: line seems to say they aren't
> interested in individual drivers...

This is a 'bug', of course. :-) Thanks for the report.

This is what I've just applied:

- - - -
MAINTAINERS: Fix 'F' entry for the power supply class

For some reason the maintainers file only specifies power
supply core files.

We're surely interested in individual drivers as well, so fix
the entry.

Reported-by: NeilBrown <[email protected]>
Signed-off-by: Anton Vorontsov <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index bb76fc4..3766f6a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5290,7 +5290,7 @@ M: David Woodhouse <[email protected]>
T: git git://git.infradead.org/battery-2.6.git
S: Maintained
F: include/linux/power_supply.h
-F: drivers/power/power_supply*
+F: drivers/power/

PNP SUPPORT
M: Adam Belay <[email protected]>
--
1.7.9.2


2012-05-05 10:54:13

by Anton Vorontsov

[permalink] [raw]
Subject: Re: [PATCH 0/6] twl4030: Various fixes for charing-from-USB

On Sat, May 05, 2012 at 03:49:10AM -0700, Anton Vorontsov wrote:
> On Mon, Apr 30, 2012 at 09:30:02AM +1000, NeilBrown wrote:
> > > > Following are a collection of patches that I've need using for a while
> > > > to make sure the charge-from-usb on my GTA04 works.
> > > > Hopefully I've included the right people in the recipient list :-)
> > >
> > > You missed the power supply maintainers - ./scripts/get_maintainer.pl
> > > is usually good at finding the right people, although their
> > > MAINTAINERS entry could be better I guess..
> > >
> > >
> >
> > I guess you mean:
> >
> > POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
> > M: Anton Vorontsov <[email protected]>
> > M: David Woodhouse <[email protected]>
> > T: git git://git.infradead.org/battery-2.6.git
> > S: Maintained
> > F: include/linux/power_supply.h
> > F: drivers/power/power_supply*
> >
> >
> > get_maintainer.pl didn't find them. The F: line seems to say they aren't
> > interested in individual drivers...
>
> This is a 'bug', of course. :-) Thanks for the report.
>
> This is what I've just applied:
>
> - - - -
> MAINTAINERS: Fix 'F' entry for the power supply class
>
> For some reason the maintainers file only specifies power
> supply core files.
>
> We're surely interested in individual drivers as well, so fix
> the entry.
>
> Reported-by: NeilBrown <[email protected]>

Oh, Grazvydas Ignotas noticed this too. I added
Reported-by: Grazvydas Ignotas <[email protected]> as well.
Just to be precise. ;-)

Thanks folks,

--
Anton Vorontsov
Email: [email protected]