From: Wanpeng Li <[email protected]>
Signed-off-by: Wanpeng Li <[email protected]>
---
mm/page-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 26adea8..2b317a3 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1155,7 +1155,7 @@ static long bdi_min_pause(struct backing_dev_info *bdi,
* balance_dirty_pages() must be called by processes which are generating dirty
* data. It looks at the number of dirty pages in the machine and will force
* the caller to wait once crossing the (background_thresh + dirty_thresh) / 2.
- * If we're over `background_thresh' then the writeback threads are woken to
+ * If we're over 'background_thresh' then the writeback threads are woken to
* perform some writeout.
*/
static void balance_dirty_pages(struct address_space *mapping,
--
1.7.9.5
On 12.05.2012 12:47, [email protected] wrote:
> - * If we're over `background_thresh' then the writeback threads are woken to
> + * If we're over 'background_thresh' then the writeback threads are woken to
I can't say the original is wrong. Since these quotes don't have
"open" and "close" versions like {} or () pairs does, people often
use ` as opening and ' as closing - while staying within ascii.
Alternatives are things like « » or other things, but these aren't
ascii anymore. So I'd say keep it alone... ;)
/mjt
On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
> On 12.05.2012 12:47, [email protected] wrote:
> > - * If we're over `background_thresh' then the writeback threads are woken to
> > + * If we're over 'background_thresh' then the writeback threads are woken to
>
> I can't say the original is wrong. Since these quotes don't have
> "open" and "close" versions like {} or () pairs does, people often
> use ` as opening and ' as closing - while staying within ascii.
> Alternatives are things like « » or other things, but these aren't
> ascii anymore. So I'd say keep it alone... ;)
Agreed. For example, latex uses ` and ' as opening and closing pairs.
That does look a bit weird for C and shell users ;)
Thanks,
Fengguang
On Sat, May 12, 2012 at 07:26:37PM +0800, Fengguang Wu wrote:
> On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
> > On 12.05.2012 12:47, [email protected] wrote:
> > > - * If we're over `background_thresh' then the writeback threads are woken to
> > > + * If we're over 'background_thresh' then the writeback threads are woken to
> >
> > I can't say the original is wrong. Since these quotes don't have
> > "open" and "close" versions like {} or () pairs does, people often
> > use ` as opening and ' as closing - while staying within ascii.
> > Alternatives are things like ? ? or other things, but these aren't
> > ascii anymore. So I'd say keep it alone... ;)
>
> Agreed. For example, latex uses ` and ' as opening and closing pairs.
> That does look a bit weird for C and shell users ;)
In some fonts, ` is actually symmetrical to '.
If you change it to 'background_thresh', it will look like crap in my
S?tterlin emacs.
On Sam, 2012-05-12 at 19:26 +0800, Fengguang Wu wrote:
> On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
> > On 12.05.2012 12:47, [email protected] wrote:
> > > - * If we're over `background_thresh' then the writeback threads are woken to
> > > + * If we're over 'background_thresh' then the writeback threads are woken to
> >
> > I can't say the original is wrong. Since these quotes don't have
> > "open" and "close" versions like {} or () pairs does, people often
> > use ` as opening and ' as closing - while staying within ascii.
> > Alternatives are things like « » or other things, but these aren't
> > ascii anymore. So I'd say keep it alone... ;)
>
> Agreed. For example, latex uses ` and ' as opening and closing pairs.
m4 too.
> That does look a bit weird for C and shell users ;)
Just because they aren't used to it;-)
And shell scripting would be easier if shells had different opening and
closing quote characters.
Bernd
--
Bernd Petrovitsch Email : [email protected]
LUGA : http://www.luga.at
On Sat, May 12, 2012 at 10:09 PM, Johannes Weiner <[email protected]> wrote:
> On Sat, May 12, 2012 at 07:26:37PM +0800, Fengguang Wu wrote:
>> On Sat, May 12, 2012 at 01:02:36PM +0400, Michael Tokarev wrote:
>> > On 12.05.2012 12:47, [email protected] wrote:
>> > > - * If we're over `background_thresh' then the writeback threads are woken to
>> > > + * If we're over 'background_thresh' then the writeback threads are woken to
>> >
>> > I can't say the original is wrong. Since these quotes don't have
>> > "open" and "close" versions like {} or () pairs does, people often
>> > use ` as opening and ' as closing - while staying within ascii.
>> > Alternatives are things like « » or other things, but these aren't
>> > ascii anymore. So I'd say keep it alone... ;)
>>
>> Agreed. For example, latex uses ` and ' as opening and closing pairs.
>> That does look a bit weird for C and shell users ;)
>
> In some fonts, ` is actually symmetrical to '.
>
> If you change it to 'background_thresh', it will look like crap in my
> Sütterlin emacs.
Yup, see also,
http://english.stackexchange.com/questions/17695/any-reference-on-the-usage-of-a-backtick-and-single-quotation-mark-like-this/18669#18669