2012-05-12 11:01:18

by Dan Carpenter

Subject: [patch] mfd: lm3533: silence a gcc warning

This is supposed to be umode_t. It causes a GCC warning:
drivers/mfd/lm3533-core.c:440:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/mfd/lm3533-core.c:440:2: warning: (near initialization for ‘lm3533_attribute_group.is_visible’) [enabled by default]

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 75f4b7f..6f315d6 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -418,7 +418,7 @@ static struct attribute *lm3533_attributes[] = {
#define to_dev_attr(_attr) \
container_of(_attr, struct device_attribute, attr)

-static mode_t lm3533_attr_is_visible(struct kobject *kobj,
+static umode_t lm3533_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
struct device *dev = container_of(kobj, struct device, kobj);

2012-05-14 20:07:13

by Samuel Ortiz

Subject: Re: [patch] mfd: lm3533: silence a gcc warning

Hi Dan,

On Sat, May 12, 2012 at 02:01:04PM +0300, Dan Carpenter wrote:
> This is supposed to be umode_t. It causes a GCC warning:
> drivers/mfd/lm3533-core.c:440:2: warning: initialization from incompatible pointer type [enabled by default]
> drivers/mfd/lm3533-core.c:440:2: warning: (near initialization for ‘lm3533_attribute_group.is_visible’) [enabled by default]
>
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/