2012-05-20 00:04:57

by Eldad Zack

Subject: [PATCH] net/ipv4/ipconfig: neaten __setup placement

The __setup macro should follow the corresponding setup handler.

Signed-off-by: Eldad Zack <[email protected]>
---
net/ipv4/ipconfig.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 92ac7e7..1d8076a 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -1626,11 +1626,13 @@ static int __init ip_auto_config_setup(char *addrs)

return 1;
}
+__setup("ip=", ip_auto_config_setup);

static int __init nfsaddrs_config_setup(char *addrs)
{
return ip_auto_config_setup(addrs);
}
+__setup("nfsaddrs=", nfsaddrs_config_setup);

static int __init vendor_class_identifier_setup(char *addrs)
{
@@ -1641,7 +1643,4 @@ static int __init vendor_class_identifier_setup(char *addrs)
vendor_class_identifier);
return 1;
}
-
-__setup("ip=", ip_auto_config_setup);
-__setup("nfsaddrs=", nfsaddrs_config_setup);
__setup("dhcpclass=", vendor_class_identifier_setup);
--
1.7.10

2012-05-20 08:10:11

by David Miller

Subject: Re: [PATCH] net/ipv4/ipconfig: neaten __setup placement

From: Eldad Zack <[email protected]>
Date: Sun, 20 May 2012 02:04:39 +0200

> The __setup macro should follow the corresponding setup handler.
>
> Signed-off-by: Eldad Zack <[email protected]>

Applied.