2012-05-21 15:33:31

by Axel Lin

[permalink] [raw]
Subject: [PATCH] mfd: Add terminating entry for i2c_device_id table

The i2c_device_id table is supposed to be zero-terminated.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mfd/palmas.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index 00c0aba..5d896b3 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -472,6 +472,7 @@ static const struct i2c_device_id palmas_i2c_id[] = {
{ "twl6035", },
{ "twl6037", },
{ "tps65913", },
+ { /* end */ }
};
MODULE_DEVICE_TABLE(i2c, palmas_i2c_id);

--
1.7.5.4



2012-05-22 10:11:10

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] mfd: Add terminating entry for i2c_device_id table

On Mon, May 21, 2012 at 11:33:22PM +0800, Axel Lin wrote:
> The i2c_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <[email protected]>

Samuel, Linus already pulled the regmap tree so this should probably go
via MFD as a bug fix? Might have to wait to after -rc1 to avoid you
having to rebase though...


Attachments:
(No filename) (338.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments

2012-05-22 19:58:34

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH] mfd: Add terminating entry for i2c_device_id table

Hi Mark,

On Tue, May 22, 2012 at 11:11:07AM +0100, Mark Brown wrote:
> On Mon, May 21, 2012 at 11:33:22PM +0800, Axel Lin wrote:
> > The i2c_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <[email protected]>
>
> Samuel, Linus already pulled the regmap tree so this should probably go
> via MFD as a bug fix? Might have to wait to after -rc1 to avoid you
> having to rebase though...
Yes, I'm queueing this one for my first post merge window pull request.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/