Subject: [PATCH] xen: do not disable netfront in dom0

Netfront driver can be also useful in dom0, eg when all NICs are assigned to
some domU (aka driver domain). Then using netback in domU and netfront in dom0
is the only way to get network access in dom0.

Signed-off-by: Marek Marczykowski <[email protected]>
---
drivers/net/xen-netfront.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 698b905..e31ebff 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1953,9 +1953,6 @@ static int __init netif_init(void)
if (!xen_domain())
return -ENODEV;

- if (xen_initial_domain())
- return 0;
-
printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");

return xenbus_register_frontend(&netfront_driver);
@@ -1965,9 +1962,6 @@ module_init(netif_init);

static void __exit netif_exit(void)
{
- if (xen_initial_domain())
- return;
-
xenbus_unregister_driver(&netfront_driver);
}
module_exit(netif_exit);
--
1.7.4.4


2012-05-22 18:41:15

by Konrad Rzeszutek Wilk

[permalink] [raw]
Subject: Re: [PATCH] xen: do not disable netfront in dom0

On Sun, May 20, 2012 at 01:45:10PM +0200, Marek Marczykowski wrote:
> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
>
> Signed-off-by: Marek Marczykowski <[email protected]>

Acked-by: Konrad Rzeszutek Wilk <[email protected]>


> ---
> drivers/net/xen-netfront.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 698b905..e31ebff 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1953,9 +1953,6 @@ static int __init netif_init(void)
> if (!xen_domain())
> return -ENODEV;
>
> - if (xen_initial_domain())
> - return 0;
> -
> printk(KERN_INFO "Initialising Xen virtual ethernet driver.\n");
>
> return xenbus_register_frontend(&netfront_driver);
> @@ -1965,9 +1962,6 @@ module_init(netif_init);
>
> static void __exit netif_exit(void)
> {
> - if (xen_initial_domain())
> - return;
> -
> xenbus_unregister_driver(&netfront_driver);
> }
> module_exit(netif_exit);
> --
> 1.7.4.4

2012-05-22 19:16:11

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] xen: do not disable netfront in dom0

From: Marek Marczykowski <[email protected]>
Date: Sun, 20 May 2012 13:45:10 +0200

> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
>
> Signed-off-by: Marek Marczykowski <[email protected]>

Someone please review this and I can merge it in via the 'net' tree if
it looks OK to XEN folks.

2012-05-22 19:31:06

by Ian Campbell

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH] xen: do not disable netfront in dom0

On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote:
> From: Marek Marczykowski <[email protected]>
> Date: Sun, 20 May 2012 13:45:10 +0200
>
> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> > some domU (aka driver domain). Then using netback in domU and netfront in dom0
> > is the only way to get network access in dom0.
> >
> > Signed-off-by: Marek Marczykowski <[email protected]>
>
> Someone please review this and I can merge it in via the 'net' tree if
> it looks OK to XEN folks.

Konrad is "Xen folks" and has acked it already but FWIW:

Acked-by: Ian Campbell <[email protected]>

Ian.

>
> _______________________________________________
> Xen-devel mailing list
> [email protected]
> http://lists.xen.org/xen-devel

2012-05-22 19:41:05

by David Miller

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH] xen: do not disable netfront in dom0

From: Ian Campbell <[email protected]>
Date: Tue, 22 May 2012 20:30:28 +0100

> On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote:
>> From: Marek Marczykowski <[email protected]>
>> Date: Sun, 20 May 2012 13:45:10 +0200
>>
>> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
>> > some domU (aka driver domain). Then using netback in domU and netfront in dom0
>> > is the only way to get network access in dom0.
>> >
>> > Signed-off-by: Marek Marczykowski <[email protected]>
>>
>> Someone please review this and I can merge it in via the 'net' tree if
>> it looks OK to XEN folks.
>
> Konrad is "Xen folks" and has acked it already but FWIW:
>
> Acked-by: Ian Campbell <[email protected]>

Ok, but this patch doesn't appply cleanly at all to Linus's
current tree nor my 'net' tree (which are equal right now).

2012-05-22 19:50:03

by Konrad Rzeszutek Wilk

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH] xen: do not disable netfront in dom0

On Tue, May 22, 2012 at 03:38:47PM -0400, David Miller wrote:
> From: Ian Campbell <[email protected]>
> Date: Tue, 22 May 2012 20:30:28 +0100
>
> > On Tue, 2012-05-22 at 20:13 +0100, David Miller wrote:
> >> From: Marek Marczykowski <[email protected]>
> >> Date: Sun, 20 May 2012 13:45:10 +0200
> >>
> >> > Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> >> > some domU (aka driver domain). Then using netback in domU and netfront in dom0
> >> > is the only way to get network access in dom0.
> >> >
> >> > Signed-off-by: Marek Marczykowski <[email protected]>
> >>
> >> Someone please review this and I can merge it in via the 'net' tree if
> >> it looks OK to XEN folks.
> >
> > Konrad is "Xen folks" and has acked it already but FWIW:
> >
> > Acked-by: Ian Campbell <[email protected]>
>
> Ok, but this patch doesn't appply cleanly at all to Linus's
> current tree nor my 'net' tree (which are equal right now).

Oh no! Marek, can you repin it please (along with all the Ack's on it).

Subject: [PATCH RESENT] xen: do not disable netfront in dom0

Netfront driver can be also useful in dom0, eg when all NICs are assigned to
some domU (aka driver domain). Then using netback in domU and netfront in dom0
is the only way to get network access in dom0.

Signed-off-by: Marek Marczykowski <[email protected]>
Acked-by: Ian Campbell <[email protected]>
Acked-by: Konrad Rzeszutek Wilk <[email protected]>
---
drivers/net/xen-netfront.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 0ebbb19..2027afe 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1962,9 +1962,6 @@ static int __init netif_init(void)
if (!xen_domain())
return -ENODEV;

- if (xen_initial_domain())
- return 0;
-
if (xen_hvm_domain() && !xen_platform_pci_unplug)
return -ENODEV;

@@ -1977,9 +1974,6 @@ module_init(netif_init);

static void __exit netif_exit(void)
{
- if (xen_initial_domain())
- return;
-
xenbus_unregister_driver(&netfront_driver);
}
module_exit(netif_exit);
--
1.7.4.4

2012-05-22 20:53:09

by David Miller

[permalink] [raw]
Subject: Re: [PATCH RESENT] xen: do not disable netfront in dom0

From: Marek Marczykowski <[email protected]>
Date: Sun, 20 May 2012 13:45:10 +0200

> Netfront driver can be also useful in dom0, eg when all NICs are assigned to
> some domU (aka driver domain). Then using netback in domU and netfront in dom0
> is the only way to get network access in dom0.
>
> Signed-off-by: Marek Marczykowski <[email protected]>
> Acked-by: Ian Campbell <[email protected]>
> Acked-by: Konrad Rzeszutek Wilk <[email protected]>

Applied, thanks.