2012-05-28 16:23:24

by Andi Shyti

Subject: [PATCH] tpm: check the chip reference before using it

If a driver calls tpm_dev_vendor_release for a device already released
then the driver will oops.

Signed-off-by: Andi Shyti <[email protected]>
Signed-off-by: Peter Huewe <[email protected]>
---
drivers/char/tpm/tpm.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index ad7c732..66e4c12 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -1322,6 +1322,9 @@ EXPORT_SYMBOL_GPL(tpm_pm_resume);

void tpm_dev_vendor_release(struct tpm_chip *chip)
{
+ if (!chip)
+ return;
+
if (chip->vendor.release)
chip->vendor.release(chip->dev);

@@ -1337,6 +1340,9 @@ EXPORT_SYMBOL_GPL(tpm_dev_vendor_release);
*/
void tpm_dev_release(struct device *dev)
{
+ if (!chip)
+ return;
+
struct tpm_chip *chip = dev_get_drvdata(dev);

tpm_dev_vendor_release(chip);
--
1.7.10

2012-05-28 16:37:43

by Andi Shyti

Subject: Re: [PATCH] tpm: check the chip reference before using it

Hi,

On Mon, May 28, 2012 at 06:23:12PM +0200, Andi Shyti wrote:
> void tpm_dev_release(struct device *dev)
> {
> + if (!chip)
> + return;
> +
> struct tpm_chip *chip = dev_get_drvdata(dev);

sorry wrong patch file... this is not going to work...
I'll resend it

Andi