2012-05-28 15:21:29

by Aneesh Kumar K.V

Subject: [PATCH] mm/hugetlb: Use hstate_index instead of open coding it

From: "Aneesh Kumar K.V" <[email protected]>

Use hstate_index in hugetlb_init

Signed-off-by: Aneesh Kumar K.V <[email protected]>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 4b90dd5..58eead5 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1891,7 +1891,7 @@ static int __init hugetlb_init(void)
if (!size_to_hstate(default_hstate_size))
hugetlb_add_hstate(HUGETLB_PAGE_ORDER);
}
- default_hstate_idx = size_to_hstate(default_hstate_size) - hstates;
+ default_hstate_idx = hstate_index(size_to_hstate(default_hstate_size));
if (default_hstate_max_huge_pages)
default_hstate.max_huge_pages = default_hstate_max_huge_pages;

--
1.7.10

2012-05-28 19:14:44

by Michal Hocko

Subject: Re: [PATCH] mm/hugetlb: Use hstate_index instead of open coding it

On Mon 28-05-12 20:51:13, Aneesh Kumar K.V wrote:
> From: "Aneesh Kumar K.V" <[email protected]>
>
> Use hstate_index in hugetlb_init
>
> Signed-off-by: Aneesh Kumar K.V <[email protected]>

Reviewed-by: Michal Hocko <[email protected]>

> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 4b90dd5..58eead5 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1891,7 +1891,7 @@ static int __init hugetlb_init(void)
> if (!size_to_hstate(default_hstate_size))
> hugetlb_add_hstate(HUGETLB_PAGE_ORDER);
> }
> - default_hstate_idx = size_to_hstate(default_hstate_size) - hstates;
> + default_hstate_idx = hstate_index(size_to_hstate(default_hstate_size));
> if (default_hstate_max_huge_pages)
> default_hstate.max_huge_pages = default_hstate_max_huge_pages;
>
> --
> 1.7.10
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to [email protected]. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic