2012-05-31 11:13:06

by Christian Dietrich

[permalink] [raw]

Subject: [PATCH] gpio/msm_v1: CONFIG_GPIO_MSM_V1 is only available on three SoCs

---

The feature GPIO_MSM_V1 is only available on three SoCs. On all other MSM SoCs
the INT_GPIO_GROUP{1,2} is undeclared, but Kconfig does allow such
configurations. Therefore the produced configuration is valid, but does not
compile. The problem is fixed by adding the missing Kconfig constraints.

drivers/gpio/gpio-msm-v1.c: In function ‘msm_init_gpio’:
drivers/gpio/gpio-msm-v1.c:629:26: error: 'INT_GPIO_GROUP1' undeclared
drivers/gpio/gpio-msm-v1.c:630:26: error: 'INT_GPIO_GROUP2' undeclared

Signed-off-by: Christian Dietrich <[email protected]>
---
drivers/gpio/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

I added a configuration, which should reproduce the compilation error
directly.

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index c4067d0..542f0c0 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -136,7 +136,7 @@ config GPIO_MPC8XXX

config GPIO_MSM_V1
tristate "Qualcomm MSM GPIO v1"
- depends on GPIOLIB && ARCH_MSM
+ depends on GPIOLIB && ARCH_MSM && (ARCH_MSM7X00A || ARCH_MSM7X30 || ARCH_QSD8X50)
help
Say yes here to support the GPIO interface on ARM v6 based
Qualcomm MSM chips. Most of the pins on the MSM can be
--
1.7.5.4

---

Attachments:

(No filename) (1.22 kB)
gpio-msm-v1.config (55.29 kB)
Download all attachments

2012-06-01 01:43:40

by Linus Walleij

[permalink] [raw]

Subject: Re: [PATCH] gpio/msm_v1: CONFIG_GPIO_MSM_V1 is only available on three SoCs

---

On Thu, May 31, 2012 at 7:12 PM, Christian Dietrich
<[email protected]> wrote:

> The feature GPIO_MSM_V1 is only available on three SoCs. On all other MSM SoCs
> the INT_GPIO_GROUP{1,2} is undeclared, but Kconfig does allow such
> configurations. Therefore the produced configuration is valid, but does not
> compile. The problem is fixed by adding the missing Kconfig constraints.
>
> drivers/gpio/gpio-msm-v1.c: In function ? ?msm_init_gpio? ?:
> drivers/gpio/gpio-msm-v1.c:629:26: error: 'INT_GPIO_GROUP1' undeclared
> drivers/gpio/gpio-msm-v1.c:630:26: error: 'INT_GPIO_GROUP2' undeclared
>
> Signed-off-by: Christian Dietrich <[email protected]>

I've run into this bug when trying (and failing) to build a mainline kernel
for the DragonBoard.

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij