2012-05-07 06:23:33

by Pallala, Ramakrishna

[permalink] [raw]
Subject: [PATCH] max17042_battery: Support CHARGE_COUNTER power supply attribute

This patch adds the support for CHARGE_COUNTER power supply
attribute to max17042/47 driver.

Note:QH(Charge Counter) register is not documented in max17042 the Spec.

Signed-off-by: Ramakrishna Pallala <[email protected]>
---
drivers/power/max17042_battery.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
index 140788b..74abc6c 100644
--- a/drivers/power/max17042_battery.c
+++ b/drivers/power/max17042_battery.c
@@ -113,6 +113,7 @@ static enum power_supply_property max17042_battery_props[] = {
POWER_SUPPLY_PROP_VOLTAGE_OCV,
POWER_SUPPLY_PROP_CAPACITY,
POWER_SUPPLY_PROP_CHARGE_FULL,
+ POWER_SUPPLY_PROP_CHARGE_COUNTER,
POWER_SUPPLY_PROP_TEMP,
POWER_SUPPLY_PROP_CURRENT_NOW,
POWER_SUPPLY_PROP_CURRENT_AVG,
@@ -201,6 +202,13 @@ static int max17042_get_property(struct power_supply *psy,

val->intval = ret * 1000 / 2;
break;
+ case POWER_SUPPLY_PROP_CHARGE_COUNTER:
+ ret = max17042_read_reg(chip->client, MAX17042_QH);
+ if (ret < 0)
+ return ret;
+
+ val->intval = ret * 1000 / 2;
+ break;
case POWER_SUPPLY_PROP_TEMP:
ret = max17042_read_reg(chip->client, MAX17042_TEMP);
if (ret < 0)
--
1.7.0.4


2012-06-18 07:52:25

by Pallala, Ramakrishna

[permalink] [raw]
Subject: RE: [PATCH] max17042_battery: Support CHARGE_COUNTER power supply attribute

Hi Anton,

> Sent: Monday, May 07, 2012 10:26 AM
> To: [email protected]
> Cc: Anton Vorontsov; Anton Vorontsov; Pallala, Ramakrishna
> Subject: [PATCH] max17042_battery: Support CHARGE_COUNTER power supply
> attribute
>
> This patch adds the support for CHARGE_COUNTER power supply attribute to
> max17042/47 driver.
>
> Note:QH(Charge Counter) register is not documented in max17042 the Spec.
>
> Signed-off-by: Ramakrishna Pallala <[email protected]>
> ---
> drivers/power/max17042_battery.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>

I am waiting for the comments or ACK from you on this patch.

Thanks,
Ram

2012-06-19 23:52:58

by Anton Vorontsov

[permalink] [raw]
Subject: Re: [PATCH] max17042_battery: Support CHARGE_COUNTER power supply attribute

On Mon, May 07, 2012 at 10:25:58AM +0530, Ramakrishna Pallala wrote:
> This patch adds the support for CHARGE_COUNTER power supply
> attribute to max17042/47 driver.
>
> Note:QH(Charge Counter) register is not documented in max17042 the Spec.
>
> Signed-off-by: Ramakrishna Pallala <[email protected]>
> ---

Applied, thank you!

--
Anton Vorontsov
Email: [email protected]