2012-06-21 10:17:46

by Wu Fengguang

[permalink] [raw]
Subject: [mm:akpm 117/143] ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!

Hi all,

Yet another error on devm_gpio_request_one()... Interestingly the
patch title says "export" but does not really export the symbol...

Thanks,
Fengguang
---
Kernel build failed on

tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
head: 3ff60ad39879eca9c1016d6e29b007ddc8f6c922
commit: 779e06e1ecb540bcd1b1b8ea66f9fd96febbc898 [117/143] backlight: l4f00242t03: export and use devm_gpio_request_one()
config: i386-allmodconfig (attached as .config)

All related error/warning messages:

ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation


Attachments:
(No filename) (759.00 B)
0001-backlight-l4f00242t03-export-and-use-devm_gpio_reque.patch (3.46 kB)
.config (151.45 kB)
Download all attachments

2012-06-21 10:26:55

by Mark Brown

[permalink] [raw]
Subject: Re: [mm:akpm 117/143] ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!

On Thu, Jun 21, 2012 at 06:17:21PM +0800, [email protected] wrote:

> Yet another error on devm_gpio_request_one()... Interestingly the
> patch title says "export" but does not really export the symbol...

Yes, this patch subject is at best misleading. We really need to get
the EXPORT_SYMBOL patch merged.


Attachments:
(No filename) (310.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments

2012-06-21 10:30:20

by Jingoo Han

[permalink] [raw]
Subject: RE: akpm 117/143] ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!

On Thursday 21 June 2012 7:17 PM Fengguang Wu wrote:

>
> Hi all,
>
> Yet another error on devm_gpio_request_one()... Interestingly the
> patch title says "export" but does not really export the symbol...
>
> Thanks,
> Fengguang
> ---
> Kernel build failed on
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> head: 3ff60ad39879eca9c1016d6e29b007ddc8f6c922
> commit: 779e06e1ecb540bcd1b1b8ea66f9fd96febbc898 [117/143] backlight: l4f00242t03: export and use
> devm_gpio_request_one()
> config: i386-allmodconfig (attached as .config)
>
> All related error/warning messages:
>
> ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!

Hi Fengguang,

The patch a291ede7be8359a8986740b11b93f9c80e40210b ' backlight-l4f00242t03-use-devm_gpio_request_one-fix'
is necessary to fix the export problem.

In my opinion, Andrew Morton will fold these patches as usual.
Thank you.

Best regards,
Jingoo Han

>
> ---
> 0-DAY kernel build testing backend Open Source Technology Centre
> Fengguang Wu <[email protected]> Intel Corporation

2012-06-21 10:43:45

by Wu Fengguang

[permalink] [raw]
Subject: Re: akpm 117/143] ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!

> > ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!
>
> Hi Fengguang,
>
> The patch a291ede7be8359a8986740b11b93f9c80e40210b ' backlight-l4f00242t03-use-devm_gpio_request_one-fix'
> is necessary to fix the export problem.
>
> In my opinion, Andrew Morton will fold these patches as usual.

Err.. Sorry for the noise! This is a bit awkward situation. It seems
that I'll need to teach my scripts to detect the follow-up commits
with title "XXX-fix" and double check such commits before sending out
error reports.

Thanks,
Fengguang

2012-06-21 11:57:50

by Wu Fengguang

[permalink] [raw]
Subject: Re: akpm 117/143] ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!

On Thu, Jun 21, 2012 at 06:43:40PM +0800, Fengguang Wu wrote:
> > > ERROR: "devm_gpio_request_one" [drivers/video/backlight/l4f00242t03.ko] undefined!
> >
> > Hi Fengguang,
> >
> > The patch a291ede7be8359a8986740b11b93f9c80e40210b ' backlight-l4f00242t03-use-devm_gpio_request_one-fix'
> > is necessary to fix the export problem.
> >
> > In my opinion, Andrew Morton will fold these patches as usual.
>
> Err.. Sorry for the noise! This is a bit awkward situation. It seems
> that I'll need to teach my scripts to detect the follow-up commits
> with title "XXX-fix" and double check such commits before sending out
> error reports.

I end up with a simple workaround: since Andrew already caught and fix
the problem, why should I bother again? Just skip it :-)

And it worked:

930736bb0afef0452ee82b6d7b401b3fb937d5cd commit compiled.. skip
75f874d6fe0ad7fdfe3b205f59b21462cf1e62b3 commit compiled.. skip
779e06e1ecb540bcd1b1b8ea66f9fd96febbc898 has akpm fix..... skip backlight: l4f00242t03: export and use devm_gpio_request_one()
a291ede7be8359a8986740b11b93f9c80e40210b has akpm fix..... skip backlight-l4f00242t03-use-devm_gpio_request_one-fix
602610fbfdffedba02554ba1adeb4540822cd00c commit compiled.. skip

Thanks,
Fengguang