2012-06-22 05:53:00

by Sherwin Soltani

Subject: [PATCH] Staging: android: logger.c: fixed some printk macros

Changed a few printk messages in logger.c to make checkpatch.pl happy.

Signed-off-by: Sherwin Soltani <[email protected]>
---
drivers/staging/android/logger.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index b2e71c6..b490c5c 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -621,13 +621,13 @@ static int __init create_log(char *log_name, int size)
/* finally, initialize the misc device for this log */
ret = misc_register(&log->misc);
if (unlikely(ret)) {
- printk(KERN_ERR "logger: failed to register misc "
- "device for log '%s'!\n", log->misc.name);
+ pr_err("logger: failed to register misc device for log '%s'!\n",
+ log->misc.name);
goto out_free_log;
}

- printk(KERN_INFO "logger: created %luK log '%s'\n",
- (unsigned long) log->size >> 10, log->misc.name);
+ pr_info("logger: created %luK log '%s'\n",
+ (unsigned long) log->size >> 10, log->misc.name);

return 0;

--
1.7.9.5

2012-06-23 04:03:36

by Greg KH

Subject: Re: [PATCH] Staging: android: logger.c: fixed some printk macros

On Fri, Jun 22, 2012 at 01:44:46AM -0400, Sherwin Soltani wrote:
> Changed a few printk messages in logger.c to make checkpatch.pl happy.
>
> Signed-off-by: Sherwin Soltani <[email protected]>
> ---
> drivers/staging/android/logger.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

This patch does not apply, did you make it against Linus's tree or
linux-next? You need to always work off of linux-next please.

thanks,

greg k-h

2012-06-23 05:43:11

by Sherwin Soltani

Subject: Re: [PATCH] Staging: android: logger.c: fixed some printk macros

On 06/23/2012 12:03 AM, Greg KH wrote:
> This patch does not apply, did you make it against Linus's tree or
> linux-next? You need to always work off of linux-next please.
>
> thanks,
>
> greg k-h

Sorry, my mistake. I'll rewrite the patch working off of linux-next and
resubmit.

Sherwin