2012-06-25 20:58:25

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH -next] av32: Make sure _TIF_BREAKPOINT is defined

commit 1deb667af4fc713364fed72ccdf217162b62ec7f ("avr32: trim masks")
replaced "1 << TIF_BREAKPOINT" by "_TIF_BREAKPOINT", but forgot to define
the latter:

arch/avr32/kernel/entry-avr32b.S: Assembler messages:
arch/avr32/kernel/entry-avr32b.S:232: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:258: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:631: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:631: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation

Add the missing definition to fix this.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/6585460/
http://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.2.4/
---
arch/avr32/include/asm/thread_info.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/avr32/include/asm/thread_info.h b/arch/avr32/include/asm/thread_info.h
index 2f0c412..6dc62e1 100644
--- a/arch/avr32/include/asm/thread_info.h
+++ b/arch/avr32/include/asm/thread_info.h
@@ -89,6 +89,7 @@ static inline struct thread_info *current_thread_info(void)
#define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE)
#define _TIF_SIGPENDING (1 << TIF_SIGPENDING)
#define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED)
+#define _TIF_BREAKPOINT (1 << TIF_BREAKPOINT)
#define _TIF_SINGLE_STEP (1 << TIF_SINGLE_STEP)
#define _TIF_MEMDIE (1 << TIF_MEMDIE)
#define _TIF_CPU_GOING_TO_SLEEP (1 << TIF_CPU_GOING_TO_SLEEP)
--
1.7.0.4


Subject: Re: [PATCH -next] av32: Make sure _TIF_BREAKPOINT is defined

Around Mon 25 Jun 2012 22:58:16 +0200 or thereabout, Geert Uytterhoeven wrote:
> commit 1deb667af4fc713364fed72ccdf217162b62ec7f ("avr32: trim masks")
> replaced "1 << TIF_BREAKPOINT" by "_TIF_BREAKPOINT", but forgot to define
> the latter:
>
> arch/avr32/kernel/entry-avr32b.S: Assembler messages:
> arch/avr32/kernel/entry-avr32b.S:232: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:258: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:631: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:631: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
> arch/avr32/kernel/entry-avr32b.S:852: Error: undefined symbol `_TIF_BREAKPOINT' in operation
>
> Add the missing definition to fix this.

Thanks for fixing this.

>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Hans-Christian Egtvedt <[email protected]>

<snipp>

--
mvh
Hans-Christian Egtvedt