2012-06-08 17:00:22

by Paul Bolle

[permalink] [raw]
Subject: [PATCH] avr32: Remove unused asm/numnodes.h

This is handled with config options now.

Signed-off-by: Paul Bolle <[email protected]>
---
0) Previous, inspirational, patch:
30957a8 ("[SPARC64]: Remove unused asm-sparc64/numnodes.h")

1) Tested basically like this:
$ git grep -n "numnodes\.h"
$ git grep -n "define[[:space:]]*NODES_SHIFT\b"
arch/avr32/include/asm/numnodes.h:5:#define NODES_SHIFT 2
include/linux/numa.h:6:#define NODES_SHIFT CONFIG_NODES_SHIFT
include/linux/numa.h:8:#define NODES_SHIFT 0
$

arch/avr32/include/asm/numnodes.h | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
delete mode 100644 arch/avr32/include/asm/numnodes.h

diff --git a/arch/avr32/include/asm/numnodes.h b/arch/avr32/include/asm/numnodes.h
deleted file mode 100644
index 0b864d7..0000000
--- a/arch/avr32/include/asm/numnodes.h
+++ /dev/null
@@ -1,7 +0,0 @@
-#ifndef __ASM_AVR32_NUMNODES_H
-#define __ASM_AVR32_NUMNODES_H
-
-/* Max 4 nodes */
-#define NODES_SHIFT 2
-
-#endif /* __ASM_AVR32_NUMNODES_H */
--
1.7.7.6


Subject: Re: [PATCH] avr32: Remove unused asm/numnodes.h

Around Fri 08 Jun 2012 19:00:15 +0200 or thereabout, Paul Bolle wrote:
> This is handled with config options now.
>

Yes, but AVR32 doesn't have those bits in arch/avr32/Kconfig, hence removing
the NODES_SHIFT definition will reduce it to 0 in include/Linux/numa.h. I
suspect it is already done...

> Signed-off-by: Paul Bolle <[email protected]>
> ---
> 0) Previous, inspirational, patch:
> 30957a8 ("[SPARC64]: Remove unused asm-sparc64/numnodes.h")
>
> 1) Tested basically like this:
> $ git grep -n "numnodes\.h"
> $ git grep -n "define[[:space:]]*NODES_SHIFT\b"
> arch/avr32/include/asm/numnodes.h:5:#define NODES_SHIFT 2
> include/linux/numa.h:6:#define NODES_SHIFT CONFIG_NODES_SHIFT
> include/linux/numa.h:8:#define NODES_SHIFT 0
> $
>
> arch/avr32/include/asm/numnodes.h | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
> delete mode 100644 arch/avr32/include/asm/numnodes.h
>
> diff --git a/arch/avr32/include/asm/numnodes.h b/arch/avr32/include/asm/numnodes.h
> deleted file mode 100644
> index 0b864d7..0000000
> --- a/arch/avr32/include/asm/numnodes.h
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -#ifndef __ASM_AVR32_NUMNODES_H
> -#define __ASM_AVR32_NUMNODES_H
> -
> -/* Max 4 nodes */
> -#define NODES_SHIFT 2
> -
> -#endif /* __ASM_AVR32_NUMNODES_H */
--
mvh
Hans-Christian Egtvedt

2012-06-26 08:09:46

by Paul Bolle

[permalink] [raw]
Subject: Re: [PATCH] avr32: Remove unused asm/numnodes.h

Hans-Christian,

On Tue, 2012-06-26 at 09:32 +0200, Hans-Christian Egtvedt wrote:
> Around Fri 08 Jun 2012 19:00:15 +0200 or thereabout, Paul Bolle wrote:
> > This is handled with config options now.
>
> Yes, but AVR32 doesn't have those bits in arch/avr32/Kconfig,

Correct. Currently only 11 of 26 architectures set the Kconfig symbol
NODES_SHIFT. avr32 is not one of those 11.

> hence removing
> the NODES_SHIFT definition will reduce it to 0 in include/Linux/numa.h. I
> suspect it is already done...

Sure, NODES_SHIFT will be defined as 0 in numa.h for avr32, because
CONFIG_NODES_SHIFT will never be defined for avr32.

Or do you mean that some file is actually using avr32's asm/numnodes.h?
How does that work?


Paul Bolle