Mauro,
This patch moves the sta2x11_vip driver to the staging directory. In my opinion
this driver is not ready for prime-time.
As I mentioned a week ago, I never saw this driver when it was posted as that
was during a period were I was unavoidably absent from the list. The problem
with this driver is that it doesn't use any of the new frameworks (the control
framework and videobuf2 in particular), and this should be corrected first.
In addition it has a clear V4L2 API violation in that only one filehandle at
a time can open the video node. Developers really *must* run v4l2-compliance
before posting a new driver! Almost all of this would be caught by that tool
(except for using videobuf instead of vb2). Personally I think showing the
output of v4l2-compliance should be a requirement for getting a driver merged
under drivers/media/video.
I didn't get any reply from Federico when I posted my concerns last week, so
that makes me unhappy as well.
I hope the author will fix these issues, but in the meantime this will move
it to staging waiting for further developments.
Regards,
Hans
The following changes since commit 5472d3f17845c4398c6a510b46855820920c2181:
[media] mt9m032: Implement V4L2_CID_PIXEL_RATE control (2012-05-24 09:27:24 -0300)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git sta2x11
for you to fetch changes up to 66e2c2572a2b59df5d9f6043c5706a73ce624f89:
sta2x11_vip: move to staging. (2012-05-26 09:27:15 +0200)
----------------------------------------------------------------
Hans Verkuil (1):
sta2x11_vip: move to staging.
drivers/media/video/Kconfig | 13 -------------
drivers/media/video/Makefile | 1 -
drivers/staging/media/Kconfig | 2 ++
drivers/staging/media/Makefile | 1 +
drivers/staging/media/sta2x11/Kconfig | 12 ++++++++++++
drivers/staging/media/sta2x11/Makefile | 1 +
drivers/{media/video => staging/media/sta2x11}/sta2x11_vip.c | 0
drivers/{media/video => staging/media/sta2x11}/sta2x11_vip.h | 0
8 files changed, 16 insertions(+), 14 deletions(-)
create mode 100644 drivers/staging/media/sta2x11/Kconfig
create mode 100644 drivers/staging/media/sta2x11/Makefile
rename drivers/{media/video => staging/media/sta2x11}/sta2x11_vip.c (100%)
rename drivers/{media/video => staging/media/sta2x11}/sta2x11_vip.h (100%)
On Mon May 28 2012 13:47:43 Federico Vaga wrote:
> > I didn't get any reply from Federico when I posted my concerns last
> > week, so that makes me unhappy as well.
> >
> > I hope the author will fix these issues, but in the meantime this will
> > move it to staging waiting for further developments.
>
> The last time I worked on this device was 2 month and half ago (RFC
> time) and before answer "Ok, I'll fix it" I'm trying to understand if me
> or someone else will do that work. I'll provide a better answer than
> this when I have more information.
>
> Sorry for not sending an ack immediately, but be reassured that I'm
> still on the hardware and following the developments.
Thank you for the feedback! Suddenly I feel a lot happier :-)
You were just unlucky that you posted the driver just in a period where I
was almost completely absent from the list due to personal circumstances.
Otherwise you would have gotten the feedback at that time.
Regards,
Hans
On Mon 28 May 2012 13:47:43 Federico Vaga wrote:
> > I didn't get any reply from Federico when I posted my concerns last
> > week, so that makes me unhappy as well.
> >
> > I hope the author will fix these issues, but in the meantime this will
> > move it to staging waiting for further developments.
>
> The last time I worked on this device was 2 month and half ago (RFC
> time) and before answer "Ok, I'll fix it" I'm trying to understand if me
> or someone else will do that work. I'll provide a better answer than
> this when I have more information.
>
> Sorry for not sending an ack immediately, but be reassured that I'm
> still on the hardware and following the developments.
Hi Federico,
Any news on this?
Regards,
Hans
> Hi Federico,
>
> Any news on this?
Not at the moment. I'll ask for detail :)
--
Federico Vaga