2012-08-01 16:57:43

by Ville Syrjälä

[permalink] [raw]
Subject: Re: [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data

On Tue, Jul 31, 2012 at 08:19:06AM +0200, Daniel Mack wrote:
> On 31.07.2012 02:59, Ville Syrj?l? wrote:
> > On Mon, Jul 30, 2012 at 10:12:39PM +0400, Evgeniy Polyakov wrote:
> >> Hi
> >>
> >> Sorry for long delay
> >> [resend with fixed Greg's address :)]
> >>
> >> On Wed, Jul 25, 2012 at 10:54:29PM +0200, Daniel Mack ([email protected]) wrote:
> >>> In the process of porting boards to devicetree implemenation, we should
> >>> keep information about external circuitry where they belong - the
> >>> individual drivers.
> >>>
> >>> This patch adds a way to specify a GPIO to drive the (optional) external
> >>> pull-up logic, rather than using a function pointer for that.
> >>
> >> I do not object against this patch, but I have rather limited knowledge
> >> about gpio driver. Patch looks good, feel free to add my
> >> Acked-by: Evgeniy Polyakov <[email protected]>
> >>
> >> Greg, please pull it into your tree, if Ville does not object.
> >
> > No objections from me.
>
> I take this as an Acked-by:?

Sure, why not :)

Acked-by: Ville Syrj?l? <[email protected]>

--
Ville Syrj?l?
[email protected]
http://www.sci.fi/~syrjala/


2012-08-05 16:18:10

by Daniel Mack

[permalink] [raw]
Subject: Re: [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data

On 01.08.2012 18:57, Ville Syrjälä wrote:
> On Tue, Jul 31, 2012 at 08:19:06AM +0200, Daniel Mack wrote:
>> On 31.07.2012 02:59, Ville Syrjälä wrote:
>>> On Mon, Jul 30, 2012 at 10:12:39PM +0400, Evgeniy Polyakov wrote:
>>>> Hi
>>>>
>>>> Sorry for long delay
>>>> [resend with fixed Greg's address :)]
>>>>
>>>> On Wed, Jul 25, 2012 at 10:54:29PM +0200, Daniel Mack ([email protected]) wrote:
>>>>> In the process of porting boards to devicetree implemenation, we should
>>>>> keep information about external circuitry where they belong - the
>>>>> individual drivers.
>>>>>
>>>>> This patch adds a way to specify a GPIO to drive the (optional) external
>>>>> pull-up logic, rather than using a function pointer for that.
>>>>
>>>> I do not object against this patch, but I have rather limited knowledge
>>>> about gpio driver. Patch looks good, feel free to add my
>>>> Acked-by: Evgeniy Polyakov <[email protected]>
>>>>
>>>> Greg, please pull it into your tree, if Ville does not object.
>>>
>>> No objections from me.
>>
>> I take this as an Acked-by:?
>
> Sure, why not :)
>
> Acked-by: Ville Syrjälä <[email protected]>
>

Greg, could you queue up these two patches somewhere?


Thanks,
Daniel

2012-08-16 16:57:22

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 1/2] onewire: w1-gpio: add ext_pullup_enable pin in platform data

On Sun, Aug 05, 2012 at 06:18:01PM +0200, Daniel Mack wrote:
> On 01.08.2012 18:57, Ville Syrj?l? wrote:
> > On Tue, Jul 31, 2012 at 08:19:06AM +0200, Daniel Mack wrote:
> >> On 31.07.2012 02:59, Ville Syrj?l? wrote:
> >>> On Mon, Jul 30, 2012 at 10:12:39PM +0400, Evgeniy Polyakov wrote:
> >>>> Hi
> >>>>
> >>>> Sorry for long delay
> >>>> [resend with fixed Greg's address :)]
> >>>>
> >>>> On Wed, Jul 25, 2012 at 10:54:29PM +0200, Daniel Mack ([email protected]) wrote:
> >>>>> In the process of porting boards to devicetree implemenation, we should
> >>>>> keep information about external circuitry where they belong - the
> >>>>> individual drivers.
> >>>>>
> >>>>> This patch adds a way to specify a GPIO to drive the (optional) external
> >>>>> pull-up logic, rather than using a function pointer for that.
> >>>>
> >>>> I do not object against this patch, but I have rather limited knowledge
> >>>> about gpio driver. Patch looks good, feel free to add my
> >>>> Acked-by: Evgeniy Polyakov <[email protected]>
> >>>>
> >>>> Greg, please pull it into your tree, if Ville does not object.
> >>>
> >>> No objections from me.
> >>
> >> I take this as an Acked-by:?
> >
> > Sure, why not :)
> >
> > Acked-by: Ville Syrj?l? <[email protected]>
> >
>
> Greg, could you queue up these two patches somewhere?

Yes, I now have them, thanks.

greg k-h