2012-08-02 16:56:22

by Marcin Slusarz

[permalink] [raw]
Subject: Re: drm/nouveau: crash regression in 3.5

On Thu, Aug 02, 2012 at 01:26:55PM +0200, Ortwin Glück wrote:
> I have managed to turn the crash into a WARN_ON, by adding this to the
> begin of nouveau_software_vblank():
>
> if (!psw) {
> WARN_ON(1);
> return;
> }

Yes, I know about it, but this change fixes only a symptom. We should not get
into this code at all without enabling vblank.

> And I have also managed to load the module manually instead by udev. So
> I am happy to attach a full log of what's going on here. See also my
> added printk's starting with XXX that mark some interesting points in
> the initialization.
>
> This should give you enough information to track down the cause of the
> problem. To my non-expert eyes it looks like "noaccel" prevents
> registration of NVOBJ_ENGINE_SW or at least delays it too much.

Yes, that's what I wrote in my last patch - with noaccel it's not registered,
which leads to NULL pointer derefence.

I'm currently out of ideas why my patch does not work. But I have some ideas
how to debug it. Can you come to nouveau IRC channel at freenode and do some
additional tests? My nick is "joi" and I'm available on IRC between 6pm and
11pm CEST.

Marcin


2012-10-30 17:47:43

by Ortwin Glück

[permalink] [raw]
Subject: Re: drm/nouveau: crash regression in 3.5

On 02.08.2012 18:56, Marcin Slusarz wrote:
> On Thu, Aug 02, 2012 at 01:26:55PM +0200, Ortwin Glück wrote:
>> I have managed to turn the crash into a WARN_ON, by adding this to the
>> begin of nouveau_software_vblank():
>>
>> if (!psw) {
>> WARN_ON(1);
>> return;
>> }
>
> Yes, I know about it, but this change fixes only a symptom. We should not get
> into this code at all without enabling vblank.

I was wondering if that is ever going to be fixed in stable. Nouveau is
broken due to this bug in 3.5 and 3.6 on HP laptops -- not terribly
exotic hardware, is it? Is there any reason why this should not be
submitted to stable?

Ortwin