2012-08-10 11:46:28

by majianpeng

[permalink] [raw]
Subject: [PATCH 3/3] block: Remove unnecessary requests sort.

When adding request to plug,it already sort.So there is not unnecessary.

Signed-off-by: Jianpeng Ma <[email protected]>
---
block/blk-core.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 034f186..9dbdef6 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2879,13 +2879,6 @@ void blk_start_plug(struct blk_plug *plug)
}
EXPORT_SYMBOL(blk_start_plug);

-static int plug_rq_cmp(void *priv, struct list_head *a, struct list_head *b)
-{
- struct request *rqa = container_of(a, struct request, queuelist);
- struct request *rqb = container_of(b, struct request, queuelist);
-
- return !(rqa->q <= rqb->q);
-}

/*
* If 'from_schedule' is true, then postpone the dispatch of requests
@@ -2980,11 +2973,6 @@ void blk_flush_plug_list(struct blk_plug *plug, bool from_schedule)

list_splice_init(&plug->list, &list);

- if (plug->should_sort) {
- list_sort(NULL, &list, plug_rq_cmp);
- plug->should_sort = 0;
- }
-
q = NULL;
depth = 0;

--
1.7.9.5
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?