2012-08-20 06:58:31

by Jovi Zhang

Subject: [PATCH] pstore: add missed platform_device_unregister

>From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
From: Jovi Zhang <[email protected]>
Date: Mon, 20 Aug 2012 14:20:01 +0800
Subject: [PATCH] pstore: add missed platform_device_unregister

we need unregister platform device when module exit, add it.

Signed-off-by: Jovi Zhang <[email protected]>
---
fs/pstore/ram.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 0b311bc..adb218a 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
static void __exit ramoops_exit(void)
{
platform_driver_unregister(&ramoops_driver);
+ platform_device_unregister(dummy);
kfree(dummy_data);
}
module_exit(ramoops_exit);
--
1.7.9.7

2012-08-21 01:42:25

by Anton Vorontsov

Subject: Re: [PATCH] pstore: add missed platform_device_unregister

On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
> From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <[email protected]>
> Date: Mon, 20 Aug 2012 14:20:01 +0800
> Subject: [PATCH] pstore: add missed platform_device_unregister
>
> we need unregister platform device when module exit, add it.
>
> Signed-off-by: Jovi Zhang <[email protected]>
> ---
> fs/pstore/ram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 0b311bc..adb218a 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
> static void __exit ramoops_exit(void)
> {
> platform_driver_unregister(&ramoops_driver);
> + platform_device_unregister(dummy);
> kfree(dummy_data);
> }
> module_exit(ramoops_exit);

It looks OK to me. Unless there are objections I'll apply it to
linux-pstore.git.

Thanks!

2012-08-21 16:19:24

by Kees Cook

Subject: Re: [PATCH] pstore: add missed platform_device_unregister

On Mon, Aug 20, 2012 at 6:40 PM, Anton Vorontsov <[email protected]> wrote:
> On Mon, Aug 20, 2012 at 02:58:26PM +0800, Jovi Zhang wrote:
>> From 152373a6262045d19023cf45de84ad3c69316a45 Mon Sep 17 00:00:00 2001
>> From: Jovi Zhang <[email protected]>
>> Date: Mon, 20 Aug 2012 14:20:01 +0800
>> Subject: [PATCH] pstore: add missed platform_device_unregister
>>
>> we need unregister platform device when module exit, add it.
>>
>> Signed-off-by: Jovi Zhang <[email protected]>
>> ---
>> fs/pstore/ram.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
>> index 0b311bc..adb218a 100644
>> --- a/fs/pstore/ram.c
>> +++ b/fs/pstore/ram.c
>> @@ -537,6 +537,7 @@ postcore_initcall(ramoops_init);
>> static void __exit ramoops_exit(void)
>> {
>> platform_driver_unregister(&ramoops_driver);
>> + platform_device_unregister(dummy);
>> kfree(dummy_data);
>> }
>> module_exit(ramoops_exit);
>
> It looks OK to me. Unless there are objections I'll apply it to
> linux-pstore.git.

Yup, looks right.

Acked-by: Kees Cook <[email protected]>

-Kees

--
Kees Cook
Chrome OS Security

2012-08-22 02:51:00

by Anton Vorontsov

Subject: Re: [PATCH] pstore: add missed platform_device_unregister

On Tue, Aug 21, 2012 at 09:19:15AM -0700, Kees Cook wrote:
[...]
> >> static void __exit ramoops_exit(void)
> >> {
> >> platform_driver_unregister(&ramoops_driver);
> >> + platform_device_unregister(dummy);
> >> kfree(dummy_data);
> >> }
> >> module_exit(ramoops_exit);
> >
> > It looks OK to me. Unless there are objections I'll apply it to
> > linux-pstore.git.
>
> Yup, looks right.
>
> Acked-by: Kees Cook <[email protected]>

Applied, thanks!