2012-08-02 10:10:21

by Axel Lin

Subject: [PATCH] iio: lm3533-als: Fix build warnings

Fix below build warnings:
CC [M] drivers/iio/light/lm3533-als.o
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]

Signed-off-by: Axel Lin <[email protected]>
---
drivers/iio/light/lm3533-als.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
index c3e7bac..e45712a9 100644
--- a/drivers/iio/light/lm3533-als.c
+++ b/drivers/iio/light/lm3533-als.c
@@ -404,7 +404,7 @@ out:
return ret;
}

-static int show_thresh_either_en(struct device *dev,
+static ssize_t show_thresh_either_en(struct device *dev,
struct device_attribute *attr,
char *buf)
{
@@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
}

-static int store_thresh_either_en(struct device *dev,
+static ssize_t store_thresh_either_en(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t len)
{
--
1.7.9.5

2012-08-14 20:29:26

by Jonathan Cameron

Subject: Re: [PATCH] iio: lm3533-als: Fix build warnings

On 08/02/2012 11:10 AM, Axel Lin wrote:
> Fix below build warnings:
> CC [M] drivers/iio/light/lm3533-als.o
> drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
>
> Signed-off-by: Axel Lin <[email protected]>
Thanks queued up.
> ---
> drivers/iio/light/lm3533-als.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> index c3e7bac..e45712a9 100644
> --- a/drivers/iio/light/lm3533-als.c
> +++ b/drivers/iio/light/lm3533-als.c
> @@ -404,7 +404,7 @@ out:
> return ret;
> }
>
> -static int show_thresh_either_en(struct device *dev,
> +static ssize_t show_thresh_either_en(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {
> @@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
> return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
> }
>
> -static int store_thresh_either_en(struct device *dev,
> +static ssize_t store_thresh_either_en(struct device *dev,
> struct device_attribute *attr,
> const char *buf, size_t len)
> {
>

2012-08-22 09:48:27

by Johan Hovold

Subject: Re: [PATCH] iio: lm3533-als: Fix build warnings

On Tue, Aug 14, 2012 at 09:29:21PM +0100, Jonathan Cameron wrote:
> On 08/02/2012 11:10 AM, Axel Lin wrote:
> > Fix below build warnings:
> > CC [M] drivers/iio/light/lm3533-als.o
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default]
> > drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
> >
> > Signed-off-by: Axel Lin <[email protected]>
> Thanks queued up.

Thanks for fixing this and sorry for not responding sooner (vacation...).

Johan

> > ---
> > drivers/iio/light/lm3533-als.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> > index c3e7bac..e45712a9 100644
> > --- a/drivers/iio/light/lm3533-als.c
> > +++ b/drivers/iio/light/lm3533-als.c
> > @@ -404,7 +404,7 @@ out:
> > return ret;
> > }
> >
> > -static int show_thresh_either_en(struct device *dev,
> > +static ssize_t show_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > char *buf)
> > {
> > @@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
> > return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
> > }
> >
> > -static int store_thresh_either_en(struct device *dev,
> > +static ssize_t store_thresh_either_en(struct device *dev,
> > struct device_attribute *attr,
> > const char *buf, size_t len)
> > {
> >