2012-10-01 07:41:39

by Daniel J Blueman

[permalink] [raw]
Subject: [PATCH] Correct AMD IOMMU printing

When an AMD IOMMU is detected, prevent printing unintended blank line.

Signed-off-by: Daniel J Blueman <[email protected]>
---
drivers/iommu/amd_iommu_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 18a89b7..49d9d32 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1115,8 +1115,8 @@ static void print_iommu_info(void)
if (iommu_feature(iommu, (1ULL << i)))
pr_cont(" %s", feat_str[i]);
}
+ pr_cont("\n");
}
- pr_cont("\n");
}
}

--
1.7.9.5


2012-10-01 07:55:56

by Joerg Roedel

[permalink] [raw]
Subject: Re: [PATCH] Correct AMD IOMMU printing

On Mon, Oct 01, 2012 at 03:41:13PM +0800, Daniel J Blueman wrote:
> When an AMD IOMMU is detected, prevent printing unintended blank line.
>
> Signed-off-by: Daniel J Blueman <[email protected]>
> ---
> drivers/iommu/amd_iommu_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 18a89b7..49d9d32 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -1115,8 +1115,8 @@ static void print_iommu_info(void)
> if (iommu_feature(iommu, (1ULL << i)))
> pr_cont(" %s", feat_str[i]);
> }
> + pr_cont("\n");
> }
> - pr_cont("\n");

Sorry, you are 3 days too late with this, Borislav Petkov already
submitted a similar patch on friday.


Joerg

--
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632