2012-10-02 13:04:50

by Florian Zumbiehl

Subject: [PATCH] drm/savage: re-add busmaster enable, regression fix

466e69b8b03b8c1987367912782bc12988ad8794 dropped busmaster enable from the
global drm code and moved it to the individual drivers, but missed the savage
driver. So, this re-adds busmaster enable to the savage driver, fixing the
regression.

Signed-off-by: Florian Zumbiehl <[email protected]>

diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
index 6eb507a..7d3f0f0 100644
--- a/drivers/gpu/drm/savage/savage_bci.c
+++ b/drivers/gpu/drm/savage/savage_bci.c
@@ -547,6 +547,8 @@ int savage_driver_load(struct drm_device *dev, unsigned long chipset)

dev_priv->chipset = (enum savage_family)chipset;

+ pci_set_master(dev->pdev);
+
return 0;
}

2012-10-02 15:08:49

by Alex Deucher

Subject: Re: [PATCH] drm/savage: re-add busmaster enable, regression fix

On Tue, Oct 2, 2012 at 8:20 AM, Florian Zumbiehl <[email protected]> wrote:
> 466e69b8b03b8c1987367912782bc12988ad8794 dropped busmaster enable from the
> global drm code and moved it to the individual drivers, but missed the savage
> driver. So, this re-adds busmaster enable to the savage driver, fixing the
> regression.
>
> Signed-off-by: Florian Zumbiehl <[email protected]>

Reviewed-by: Alex Deucher <[email protected]>

>
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index 6eb507a..7d3f0f0 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -547,6 +547,8 @@ int savage_driver_load(struct drm_device *dev, unsigned long chipset)
>
> dev_priv->chipset = (enum savage_family)chipset;
>
> + pci_set_master(dev->pdev);
> +
> return 0;
> }
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/dri-devel