2012-10-04 22:59:51

by Dave Jones

Subject: virtio build breakage.

After linking, I see this..

ERROR: "virtqueue_kick" [net/9p/9pnet_virtio.ko] undefined!
ERROR: "virtqueue_get_buf" [net/9p/9pnet_virtio.ko] undefined!
ERROR: "virtqueue_add_buf" [net/9p/9pnet_virtio.ko] undefined!
ERROR: "virtqueue_notify" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_kick_prepare" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_kick" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_enable_cb" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "virtqueue_disable_cb" [drivers/scsi/virtio_scsi.ko] undefined!
ERROR: "vring_del_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_new_virtqueue" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_interrupt" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "vring_transport_features" [drivers/remoteproc/remoteproc.ko] undefined!
ERROR: "virtqueue_enable_cb_delayed" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_enable_cb" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_kick" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_disable_cb" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_detach_unused_buf" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_get_vring_size" [drivers/net/virtio_net.ko] undefined!
ERROR: "virtqueue_disable_cb" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_detach_unused_buf" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_kick" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/char/virtio_console.ko] undefined!
ERROR: "virtqueue_kick" [drivers/char/hw_random/virtio-rng.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/char/hw_random/virtio-rng.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/char/hw_random/virtio-rng.ko] undefined!
ERROR: "virtqueue_kick" [drivers/block/virtio_blk.ko] undefined!
ERROR: "virtqueue_add_buf" [drivers/block/virtio_blk.ko] undefined!
ERROR: "virtqueue_get_buf" [drivers/block/virtio_blk.ko] undefined!

config is at http://fpaste.org/svfL/raw

Dave

2012-10-06 07:35:48

by Rusty Russell

Subject: Re: virtio build breakage.

Dave Jones <[email protected]> writes:

> After linking, I see this..
>
> ERROR: "virtqueue_kick" [net/9p/9pnet_virtio.ko] undefined!
> ERROR: "virtqueue_get_buf" [net/9p/9pnet_virtio.ko] undefined!

Cool!

Someone else spotted this recently, and the fix is in my recent pull
request to Linus:

commit 04679f34c141a0591e525d392929efc249440a7c
Author: Michael S. Tsirkin <[email protected]>
Date: Fri Sep 28 15:05:14 2012 +0930

virtio-balloon: dependency fix

Devices should depend on virtio, not select it. It's supposed to be
selected by the particular driver, e.g. VIRTIO_PCI.
Make balloon depend on VIRTIO and EXPERIMENTAL
(to match description).

Signed-off-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>

diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index f38b17a..271be80 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -27,8 +27,7 @@ config VIRTIO_PCI

config VIRTIO_BALLOON
tristate "Virtio balloon driver (EXPERIMENTAL)"
- select VIRTIO
- select VIRTIO_RING
+ depends on EXPERIMENTAL && VIRTIO
---help---
This driver supports increasing and decreasing the amount
of memory within a KVM guest.