2011-04-20 18:07:50

by Seth Heasley

[permalink] [raw]
Subject: [PATCH 2.6.39-rc3] hda_intel: ALSA HD Audio patch for Intel Panther Point DeviceIDs

This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.

Signed-off-by: Seth Heasley <[email protected]>
---
--- linux-2.6.39-rc3/sound/pci/hda/hda_intel.c.orig 2011-04-11 17:21:51.000000000 -0700
+++ linux-2.6.39-rc3/sound/pci/hda/hda_intel.c 2011-04-14 11:44:40.000000000 -0700
@@ -126,6 +126,7 @@
"{Intel, ICH10},"
"{Intel, PCH},"
"{Intel, CPT},"
+ "{Intel, PPT},"
"{Intel, PBG},"
"{Intel, SCH},"
"{ATI, SB450},"
@@ -2759,6 +2760,8 @@
{ PCI_DEVICE(0x8086, 0x1c20), .driver_data = AZX_DRIVER_PCH },
/* PBG */
{ PCI_DEVICE(0x8086, 0x1d20), .driver_data = AZX_DRIVER_PCH },
+ /* Panther Point */
+ { PCI_DEVICE(0x8086, 0x1e20), .driver_data = AZX_DRIVER_PCH },
/* SCH */
{ PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH },
/* Generic Intel */


2011-04-20 19:04:28

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH 2.6.39-rc3] hda_intel: ALSA HD Audio patch for Intel Panther Point DeviceIDs

At Wed, 20 Apr 2011 10:59:57 -0700,
Seth Heasley wrote:
>
> This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
>
> Signed-off-by: Seth Heasley <[email protected]>

Applied now. Thanks.


Takashi

> ---
> --- linux-2.6.39-rc3/sound/pci/hda/hda_intel.c.orig 2011-04-11 17:21:51.000000000 -0700
> +++ linux-2.6.39-rc3/sound/pci/hda/hda_intel.c 2011-04-14 11:44:40.000000000 -0700
> @@ -126,6 +126,7 @@
> "{Intel, ICH10},"
> "{Intel, PCH},"
> "{Intel, CPT},"
> + "{Intel, PPT},"
> "{Intel, PBG},"
> "{Intel, SCH},"
> "{ATI, SB450},"
> @@ -2759,6 +2760,8 @@
> { PCI_DEVICE(0x8086, 0x1c20), .driver_data = AZX_DRIVER_PCH },
> /* PBG */
> { PCI_DEVICE(0x8086, 0x1d20), .driver_data = AZX_DRIVER_PCH },
> + /* Panther Point */
> + { PCI_DEVICE(0x8086, 0x1e20), .driver_data = AZX_DRIVER_PCH },
> /* SCH */
> { PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH },
> /* Generic Intel */
>

2012-10-09 01:07:54

by Jonathan Nieder

[permalink] [raw]
Subject: [PATCH 2.6.32.y, 2.6.34.y] ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

From: Seth Heasley <[email protected]>
Date: Wed, 20 Apr 2011 10:59:57 -0700

commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.

This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.

[jn: backported for 2.6.32.y by Ana Guerrero]

Signed-off-by: Seth Heasley <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
Tested-by: Ana Guerrero <[email protected]> # EliteBook 8570w
Signed-off-by: Jonathan Nieder <[email protected]>
---
Hi Willy and Paul,

Please consider

d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
DeviceIDs

for application to the 2.6.32.y and 2.6.34.y trees.

It does what it says on the cover. The patch was merged in the 3.0
cycle, so newer stable kernels don't need it. Backported and
tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) --
thanks!

Thoughts of all kinds welcome, as always.

Regards,
Jonathan

[1] http://bugs.debian.org/689928

sound/pci/hda/hda_intel.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 3cf21ffc7c5f..dc812838ea8b 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -126,6 +126,7 @@ MODULE_SUPPORTED_DEVICE("{{Intel, ICH6},"
"{Intel, ICH10},"
"{Intel, PCH},"
"{Intel, CPT},"
+ "{Intel, PPT},"
"{Intel, SCH},"
"{ATI, SB450},"
"{ATI, SB600},"
@@ -2730,6 +2731,8 @@ static DEFINE_PCI_DEVICE_TABLE(azx_ids) = {
{ PCI_DEVICE(0x8086, 0x3b57), .driver_data = AZX_DRIVER_ICH },
/* CPT */
{ PCI_DEVICE(0x8086, 0x1c20), .driver_data = AZX_DRIVER_PCH },
+ /* Panther Point */
+ { PCI_DEVICE(0x8086, 0x1e20), .driver_data = AZX_DRIVER_PCH },
/* SCH */
{ PCI_DEVICE(0x8086, 0x811b), .driver_data = AZX_DRIVER_SCH },
/* ATI SB 450/600 */
--
1.7.10.4

2012-10-09 01:55:57

by Ben Hutchings

[permalink] [raw]
Subject: Re: [PATCH 2.6.32.y, 2.6.34.y] ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

On Mon, 2012-10-08 at 18:07 -0700, Jonathan Nieder wrote:
> From: Seth Heasley <[email protected]>
> Date: Wed, 20 Apr 2011 10:59:57 -0700
>
> commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.
>
> This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
>
> [jn: backported for 2.6.32.y by Ana Guerrero]
>
> Signed-off-by: Seth Heasley <[email protected]>
> Signed-off-by: Takashi Iwai <[email protected]>
> Tested-by: Ana Guerrero <[email protected]> # EliteBook 8570w
> Signed-off-by: Jonathan Nieder <[email protected]>
> ---
> Hi Willy and Paul,
>
> Please consider
>
> d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
> DeviceIDs
>
> for application to the 2.6.32.y and 2.6.34.y trees.
>
> It does what it says on the cover. The patch was merged in the 3.0
> cycle, so newer stable kernels don't need it. Backported and
> tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) --
> thanks!
>
> Thoughts of all kinds welcome, as always.
[...]

I queued up a whole series of device ID updates for Debian stable, as
they didn't obviously depend on other changes:

cea310e ALSA: hda_intel: ALSA HD Audio patch for Intel Patsburg DeviceIDs
e35d4b1 ALSA: hda: add Vortex86MX PCI ids
0f0714c ALSA: hda - Add support for VMware controller
d2edeb7 ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

(They can be cherry-picked cleanly in the above order.) But if I've
missed some post-2.6.32 dependencies then I would like to know.

Ben.

--
Ben Hutchings
Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp


Attachments:
signature.asc (828.00 B)
This is a digitally signed message part

2012-10-09 14:57:24

by Paul Gortmaker

[permalink] [raw]
Subject: Re: [PATCH 2.6.32.y, 2.6.34.y] ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

On 12-10-08 09:55 PM, Ben Hutchings wrote:
> On Mon, 2012-10-08 at 18:07 -0700, Jonathan Nieder wrote:
>> From: Seth Heasley <[email protected]>
>> Date: Wed, 20 Apr 2011 10:59:57 -0700
>>
>> commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.
>>
>> This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
>>
>> [jn: backported for 2.6.32.y by Ana Guerrero]
>>
>> Signed-off-by: Seth Heasley <[email protected]>
>> Signed-off-by: Takashi Iwai <[email protected]>
>> Tested-by: Ana Guerrero <[email protected]> # EliteBook 8570w
>> Signed-off-by: Jonathan Nieder <[email protected]>
>> ---
>> Hi Willy and Paul,
>>
>> Please consider
>>
>> d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
>> DeviceIDs
>>
>> for application to the 2.6.32.y and 2.6.34.y trees.
>>
>> It does what it says on the cover. The patch was merged in the 3.0
>> cycle, so newer stable kernels don't need it. Backported and
>> tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) --
>> thanks!
>>
>> Thoughts of all kinds welcome, as always.
> [...]
>
> I queued up a whole series of device ID updates for Debian stable, as
> they didn't obviously depend on other changes:
>
> cea310e ALSA: hda_intel: ALSA HD Audio patch for Intel Patsburg DeviceIDs
> e35d4b1 ALSA: hda: add Vortex86MX PCI ids
> 0f0714c ALSA: hda - Add support for VMware controller
> d2edeb7 ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

I found that d2edeb7c6f depends (only trivially, on context) on b686453543f,
which makes a blanket class for intel IDs so that "...the driver will work
with any new control chips in future." In that respect, I guess it too
(b68645) is in the same class as the other "add more IDs" patches?

Paul.
--

>
> (They can be cherry-picked cleanly in the above order.) But if I've
> missed some post-2.6.32 dependencies then I would like to know.
>
> Ben.
>

2012-10-12 01:23:14

by Ben Hutchings

[permalink] [raw]
Subject: Re: [PATCH 2.6.32.y, 2.6.34.y] ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs

On Tue, 2012-10-09 at 10:56 -0400, Paul Gortmaker wrote:
> On 12-10-08 09:55 PM, Ben Hutchings wrote:
> > On Mon, 2012-10-08 at 18:07 -0700, Jonathan Nieder wrote:
> >> From: Seth Heasley <[email protected]>
> >> Date: Wed, 20 Apr 2011 10:59:57 -0700
> >>
> >> commit d2edeb7c6f1dada8ca7d5c23e42d604e92ae0c76 upstream.
> >>
> >> This patch adds the HD Audio Controller DeviceIDs for the Intel Panther Point PCH.
> >>
> >> [jn: backported for 2.6.32.y by Ana Guerrero]
> >>
> >> Signed-off-by: Seth Heasley <[email protected]>
> >> Signed-off-by: Takashi Iwai <[email protected]>
> >> Tested-by: Ana Guerrero <[email protected]> # EliteBook 8570w
> >> Signed-off-by: Jonathan Nieder <[email protected]>
> >> ---
> >> Hi Willy and Paul,
> >>
> >> Please consider
> >>
> >> d2edeb7c6f1d ALSA: hda - ALSA HD Audio patch for Intel Panther Point
> >> DeviceIDs
> >>
> >> for application to the 2.6.32.y and 2.6.34.y trees.
> >>
> >> It does what it says on the cover. The patch was merged in the 3.0
> >> cycle, so newer stable kernels don't need it. Backported and
> >> tested[1] against Debian's 2.6.32.y-based kernel by Ana (cc-ed) --
> >> thanks!
> >>
> >> Thoughts of all kinds welcome, as always.
> > [...]
> >
> > I queued up a whole series of device ID updates for Debian stable, as
> > they didn't obviously depend on other changes:
> >
> > cea310e ALSA: hda_intel: ALSA HD Audio patch for Intel Patsburg DeviceIDs
> > e35d4b1 ALSA: hda: add Vortex86MX PCI ids
> > 0f0714c ALSA: hda - Add support for VMware controller
> > d2edeb7 ALSA: hda - ALSA HD Audio patch for Intel Panther Point DeviceIDs
>
> I found that d2edeb7c6f depends (only trivially, on context) on b686453543f,
> which makes a blanket class for intel IDs so that "...the driver will work
> with any new control chips in future." In that respect, I guess it too
> (b68645) is in the same class as the other "add more IDs" patches?

Yes, it seems like this would also be worth adding. (Always assuming
that any functional changes it depends on are also small enough for
stable.) It's not a clean cherry-pick as the line above has changed.

Ben.

> Paul.
> --
>
> >
> > (They can be cherry-picked cleanly in the above order.) But if I've
> > missed some post-2.6.32 dependencies then I would like to know.
> >
> > Ben.
> >
>

--
Ben Hutchings
Kids! Bringing about Armageddon can be dangerous. Do not attempt it in
your own home. - Terry Pratchett and Neil Gaiman, `Good Omens'


Attachments:
signature.asc (828.00 B)
This is a digitally signed message part