On Mon, 2012-09-17 at 11:29 +0100, Matt Fleming wrote:
> From: Matt Fleming <[email protected]>
>
> The efi_enabled variable has come to mean "Do we have EFI runtime
> services available?". However, lack of EFI runtime services does not
> mean that we should switch to using the VGA console. Provided that the
> boot loader passed the dimensions of the EFI framebuffer there is no
> reason we can't use efifb.
>
> There's also no reason to check the memory type of 0xa0000 - whether
> or not that memory region is EFI_CONVENTIONAL_MEMORY is immaterial -
> the EFI framebuffer device will still work, and checking the EFI
> memory type of a memory region on a non-EFI machine is illogical.
>
> Cc: H. Peter Anvin <[email protected]>
> Cc: Matthew Garrett <[email protected]>
> Cc: Olof Johansson <[email protected]>
> Cc: Peter Jones <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Signed-off-by: Matt Fleming <[email protected]>
> ---
> arch/x86/kernel/setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Ping? Anybody got an opinion on this one?
On Wed, Oct 10, 2012 at 02:43:07PM +0100, Matt Fleming wrote:
> On Mon, 2012-09-17 at 11:29 +0100, Matt Fleming wrote:
> > From: Matt Fleming <[email protected]>
> >
> > The efi_enabled variable has come to mean "Do we have EFI runtime
> > services available?". However, lack of EFI runtime services does not
> > mean that we should switch to using the VGA console. Provided that the
> > boot loader passed the dimensions of the EFI framebuffer there is no
> > reason we can't use efifb.
> >
> > There's also no reason to check the memory type of 0xa0000 - whether
> > or not that memory region is EFI_CONVENTIONAL_MEMORY is immaterial -
> > the EFI framebuffer device will still work, and checking the EFI
> > memory type of a memory region on a non-EFI machine is illogical.
> >
> > Cc: H. Peter Anvin <[email protected]>
> > Cc: Matthew Garrett <[email protected]>
> > Cc: Olof Johansson <[email protected]>
> > Cc: Peter Jones <[email protected]>
> > Cc: Ingo Molnar <[email protected]>
> > Signed-off-by: Matt Fleming <[email protected]>
> > ---
> > arch/x86/kernel/setup.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Ping? Anybody got an opinion on this one?
Provided "video=vga" still works to circumvent Alan's objection, I'm all
for it.
--
Peter