2012-11-02 06:43:33

by Kumar Amit Mehta

Subject: [PATCH] staging: gdm72xx: wm_ioctl.h: fixed a macro coding style

fix for macro coding style.

Signed-off-by: Kumar Amit Mehta <[email protected]>
---
drivers/staging/gdm72xx/wm_ioctl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gdm72xx/wm_ioctl.h b/drivers/staging/gdm72xx/wm_ioctl.h
index 9f46e06..4ceecc4 100644
--- a/drivers/staging/gdm72xx/wm_ioctl.h
+++ b/drivers/staging/gdm72xx/wm_ioctl.h
@@ -91,7 +91,7 @@ struct wm_req_s {
};

#ifndef ifr_name
-#define ifr_name ifr_ifrn.ifrn_name
+#define ifr_name (ifr_ifrn.ifrn_name)
#endif

#endif
--
1.7.9.5

2012-11-02 06:55:59

by Dan Carpenter

Subject: Re: [PATCH] staging: gdm72xx: wm_ioctl.h: fixed a macro coding style

On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
> fix for macro coding style.
>

No. The parenthesis are not needed. I assume this is a
checkpatch.pl warning?

regards,
dan carpenter

2012-11-02 07:36:45

by Kumar Amit Mehta

Subject: Re: [PATCH] staging: gdm72xx: wm_ioctl.h: fixed a macro coding style

On Fri, Nov 02, 2012 at 09:55:55AM +0300, Dan Carpenter wrote:
> On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
> > fix for macro coding style.
> >
>
> No. The parenthesis are not needed. I assume this is a
> checkpatch.pl warning?
>
> regards,
> dan carpenter
>
Running checkpatch.pl on this file (wm_ioctl.h) returns error.

Thanks,
Amit

2012-11-02 08:15:09

by Dan Carpenter

Subject: Re: [PATCH] staging: gdm72xx: wm_ioctl.h: fixed a macro coding style

On Fri, Nov 02, 2012 at 12:36:30AM -0700, Kumar amit mehta wrote:
> On Fri, Nov 02, 2012 at 09:55:55AM +0300, Dan Carpenter wrote:
> > On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
> > > fix for macro coding style.
> > >
> >
> > No. The parenthesis are not needed. I assume this is a
> > checkpatch.pl warning?
> >
> > regards,
> > dan carpenter
> >
> Running checkpatch.pl on this file (wm_ioctl.h) returns error.
>

I think there are patches which fix checkpatch.pl for this but they
haven't been merged yet?

$ ./scripts/checkpatch.pl -f drivers/staging/gdm72xx/wm_ioctl.h
ERROR: Macros with complex values should be enclosed in parenthesis
#94: FILE: staging/gdm72xx/wm_ioctl.h:94:
+#define ifr_name ifr_ifrn.ifrn_name

total: 1 errors, 0 warnings, 97 lines checked

regards,
dan carpenter

2012-11-02 11:32:29

by Joe Perches

Subject: Re: [PATCH] staging: gdm72xx: wm_ioctl.h: fixed a macro coding style

On Fri, 2012-11-02 at 11:14 +0300, Dan Carpenter wrote:
> On Fri, Nov 02, 2012 at 12:36:30AM -0700, Kumar amit mehta wrote:
> > On Fri, Nov 02, 2012 at 09:55:55AM +0300, Dan Carpenter wrote:
> > > On Thu, Nov 01, 2012 at 11:42:59PM -0700, Kumar Amit Mehta wrote:
> > > > fix for macro coding style.
> > > >
> > >
> > > No. The parenthesis are not needed. I assume this is a
> > > checkpatch.pl warning?
> > >
> > > regards,
> > > dan carpenter
> > >
> > Running checkpatch.pl on this file (wm_ioctl.h) returns error.
> >
>
> I think there are patches which fix checkpatch.pl for this but they
> haven't been merged yet?
>
> $ ./scripts/checkpatch.pl -f drivers/staging/gdm72xx/wm_ioctl.h
> ERROR: Macros with complex values should be enclosed in parenthesis
> #94: FILE: staging/gdm72xx/wm_ioctl.h:94:
> +#define ifr_name ifr_ifrn.ifrn_name
>
> total: 1 errors, 0 warnings, 97 lines checked

Maybe:

scripts/checkpatch.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index ec58d31..b3c6a00 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2916,7 +2916,7 @@ sub process {
if ($dstat ne '' &&
$dstat !~ /^(?:$Ident|-?$Constant),$/ && # 10, // foo(),
$dstat !~ /^(?:$Ident|-?$Constant);$/ && # foo();
- $dstat !~ /^[!~-]?(?:$Ident|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo
+ $dstat !~ /^[!~-]?(?:$Ident|$Constant|$Lval)$/ && # 10 // foo() // !foo // ~foo // -foo // foo.bar[baz]->bop
$dstat !~ /^'X'$/ && # character constants
$dstat !~ /$exceptions/ &&
$dstat !~ /^\.$Ident\s*=/ && # .foo =