2012-11-09 06:06:42

by Manuel Traut

Subject: [PATCH] uio_pdrv: set memory mapping name

If uio_pdrv[_genirq] is used, the uio maps have currently no name set.
This patch sets the uio_mem name to the name of the memory resource.

Signed-off-by: Manuel Traut <[email protected]>
Reported-by: Stefan Staedtler <[email protected]>
Tested-by: Stefan Staedtler <[email protected]>

diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index 42202cd..ac988ce 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -172,6 +172,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
uiomem->memtype = UIO_MEM_PHYS;
uiomem->addr = r->start;
uiomem->size = resource_size(r);
+ uiomem->name = r->name;
++uiomem;
}

diff --git a/drivers/uio/uio_pdrv.c b/drivers/uio/uio_pdrv.c
index 72d3646..39be9e0 100644
--- a/drivers/uio/uio_pdrv.c
+++ b/drivers/uio/uio_pdrv.c
@@ -60,6 +60,7 @@ static int uio_pdrv_probe(struct platform_device *pdev)
uiomem->memtype = UIO_MEM_PHYS;
uiomem->addr = r->start;
uiomem->size = resource_size(r);
+ uiomem->name = r->name;
++uiomem;
}

2012-11-11 12:43:19

by Hans J. Koch

Subject: Re: [PATCH] uio_pdrv: set memory mapping name

On Fri, Nov 09, 2012 at 07:06:40AM +0100, Manuel Traut wrote:
> If uio_pdrv[_genirq] is used, the uio maps have currently no name set.
> This patch sets the uio_mem name to the name of the memory resource.

Looks fine to me. I added the driver's authors to Cc.

Signed-off-by: "Hans J. Koch" <[email protected]>

>
> Signed-off-by: Manuel Traut <[email protected]>
> Reported-by: Stefan Staedtler <[email protected]>
> Tested-by: Stefan Staedtler <[email protected]>
>
> diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
> index 42202cd..ac988ce 100644
> --- a/drivers/uio/uio_pdrv_genirq.c
> +++ b/drivers/uio/uio_pdrv_genirq.c
> @@ -172,6 +172,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
> uiomem->memtype = UIO_MEM_PHYS;
> uiomem->addr = r->start;
> uiomem->size = resource_size(r);
> + uiomem->name = r->name;
> ++uiomem;
> }
>
> diff --git a/drivers/uio/uio_pdrv.c b/drivers/uio/uio_pdrv.c
> index 72d3646..39be9e0 100644
> --- a/drivers/uio/uio_pdrv.c
> +++ b/drivers/uio/uio_pdrv.c
> @@ -60,6 +60,7 @@ static int uio_pdrv_probe(struct platform_device *pdev)
> uiomem->memtype = UIO_MEM_PHYS;
> uiomem->addr = r->start;
> uiomem->size = resource_size(r);
> + uiomem->name = r->name;
> ++uiomem;
> }
>
>