2012-11-11 21:10:40

by Ondrej Zary

Subject: [PATCH] snd-ice1712: enable suspend on unknown ICE1724 cards

Assume that unknown ICE1724-based cards are AC97-only that can suspend
without any additional card-specific code.

This fixes suspend on Gainward Hollywood@Home 7.1.

Signed-off-by: Ondrej Zary <[email protected]>
---
sound/pci/ice1712/ice1724.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index 5cc3fa5..aebd584 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -2363,6 +2363,8 @@ static int __devinit snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
}
printk(KERN_WARNING "ice1724: No matching model found for ID 0x%x\n",
ice->eeprom.subvendor);
+ /* assume AC97-only card which can suspend without additional code */
+ ice->pm_suspend_enabled = 1;

found:
ice->eeprom.size = snd_vt1724_read_i2c(ice, dev, 0x04);
--
Ondrej Zary

2012-11-12 09:51:15

by Takashi Iwai

Subject: Re: [alsa-devel] [PATCH] snd-ice1712: enable suspend on unknown ICE1724 cards

At Sun, 11 Nov 2012 22:10:13 +0100,
Ondrej Zary wrote:
>
> Assume that unknown ICE1724-based cards are AC97-only that can suspend
> without any additional card-specific code.
>
> This fixes suspend on Gainward Hollywood@Home 7.1.
>
> Signed-off-by: Ondrej Zary <[email protected]>

Thanks, applied.


Takashi

> ---
> sound/pci/ice1712/ice1724.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
> index 5cc3fa5..aebd584 100644
> --- a/sound/pci/ice1712/ice1724.c
> +++ b/sound/pci/ice1712/ice1724.c
> @@ -2363,6 +2363,8 @@ static int __devinit snd_vt1724_read_eeprom(struct snd_ice1712 *ice,
> }
> printk(KERN_WARNING "ice1724: No matching model found for ID 0x%x\n",
> ice->eeprom.subvendor);
> + /* assume AC97-only card which can suspend without additional code */
> + ice->pm_suspend_enabled = 1;
>
> found:
> ice->eeprom.size = snd_vt1724_read_i2c(ice, dev, 0x04);
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> [email protected]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>