2012-10-17 07:39:54

by Hannes Reinecke

Subject: [PATCH] ramoops: Fixup section annotations

The compiler complained about missing section annotations.
Fix it.

Signed-off-by: Hannes Reinecke <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: Colin Cross <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Tony Luck <[email protected]>

---
fs/pstore/ram.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 1a4f6da..2b6ebbc 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -287,8 +287,9 @@ static void ramoops_free_przs(struct ramoops_context *cxt)
kfree(cxt->przs);
}

-static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt,
- phys_addr_t *paddr, size_t dump_mem_sz)
+static int __devinit ramoops_init_przs(struct device *dev,
+ struct ramoops_context *cxt,
+ phys_addr_t *paddr, size_t dump_mem_sz)
{
int err = -ENOMEM;
int i;
@@ -326,9 +327,10 @@ fail_prz:
return err;
}

-static int ramoops_init_prz(struct device *dev, struct ramoops_context *cxt,
- struct persistent_ram_zone **prz,
- phys_addr_t *paddr, size_t sz, u32 sig)
+static int __devinit ramoops_init_prz(struct device *dev,
+ struct ramoops_context *cxt,
+ struct persistent_ram_zone **prz,
+ phys_addr_t *paddr, size_t sz, u32 sig)
{
if (!sz)
return 0;
--
1.7.4.2

2012-10-22 18:53:36

by Kees Cook

Subject: Re: [PATCH] ramoops: Fixup section annotations

On Wed, Oct 17, 2012 at 12:39 AM, Hannes Reinecke <[email protected]> wrote:
> The compiler complained about missing section annotations.
> Fix it.
>
> Signed-off-by: Hannes Reinecke <[email protected]>
> Cc: Anton Vorontsov <[email protected]>
> Cc: Colin Cross <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: Tony Luck <[email protected]>

Acked-by: Kees Cook <[email protected]>

Thanks for the fix!

-Kees

--
Kees Cook
Chrome OS Security

2012-11-17 02:46:42

by Anton Vorontsov

Subject: Re: [PATCH] ramoops: Fixup section annotations

On Mon, Oct 22, 2012 at 11:53:33AM -0700, Kees Cook wrote:
> On Wed, Oct 17, 2012 at 12:39 AM, Hannes Reinecke <[email protected]> wrote:
> > The compiler complained about missing section annotations.
> > Fix it.
> >
> > Signed-off-by: Hannes Reinecke <[email protected]>
> > Cc: Anton Vorontsov <[email protected]>
> > Cc: Colin Cross <[email protected]>
> > Cc: Kees Cook <[email protected]>
> > Cc: Tony Luck <[email protected]>
>
> Acked-by: Kees Cook <[email protected]>

Applied, thank you!