2012-11-23 05:46:14

by Lothar Waßmann

Subject: [PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV

Signed-off-by: Lothar Waßmann <[email protected]>
---
drivers/usb/chipidea/core.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index b726c49..bd6e7a4 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -479,7 +479,6 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev)
ret = ci_role_start(ci, ci->role);
if (ret) {
dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
- ret = -ENODEV;
goto rm_wq;
}

--
1.7.2.5

2012-11-23 07:01:56

by Peter Chen

Subject: Re: [PATCH] USB: chipidea: promote error code from ci_role_start() start instead of returning -ENODEV

On Thu, Nov 22, 2012 at 10:11:31AM +0100, Lothar Wa?mann wrote:
>
> Signed-off-by: Lothar Wa?mann <[email protected]>
> ---
> drivers/usb/chipidea/core.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index b726c49..bd6e7a4 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -479,7 +479,6 @@ static int __devinit ci_hdrc_probe(struct platform_device *pdev)
> ret = ci_role_start(ci, ci->role);
> if (ret) {
> dev_err(dev, "can't start %s role\n", ci_role(ci)->name);
> - ret = -ENODEV;
> goto rm_wq;
> }
Any reasons?
>
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--

Best Regards,
Peter Chen