This is probably known and fixed already, but in case it's not, let me just
mention that I saw two new warnings with ARM allyesconfig about a
__devexit being removed but the __devexit_p() still being there:
drivers/tty/serial/xilinx_uartps.c:1000:12: error: 'xuartps_remove' defined but not used [-Werror=unused-function]
drivers/usb/gadget/mv_udc_core.c:2131:12: error: 'mv_udc_remove' defined but not used [-Werror=unused-function]
Both patches were merged by Greg on Nov 19. I assume that there are a
few more, but I have not checked. These were the only ones that
caused warnings for me.
Arnd
On Mon, Nov 26, 2012 at 08:38:32PM +0000, Arnd Bergmann wrote:
> This is probably known and fixed already, but in case it's not, let me just
> mention that I saw two new warnings with ARM allyesconfig about a
> __devexit being removed but the __devexit_p() still being there:
>
> drivers/tty/serial/xilinx_uartps.c:1000:12: error: 'xuartps_remove' defined but not used [-Werror=unused-function]
> drivers/usb/gadget/mv_udc_core.c:2131:12: error: 'mv_udc_remove' defined but not used [-Werror=unused-function]
What platform has -Werror=unused-function set?
Bill, care to send follow-on patches to resolve these warnings?
thanks,
greg k-h
On Monday 26 November 2012, [email protected] wrote:
> On Mon, Nov 26, 2012 at 08:38:32PM +0000, Arnd Bergmann wrote:
> > This is probably known and fixed already, but in case it's not, let me just
> > mention that I saw two new warnings with ARM allyesconfig about a
> > __devexit being removed but the __devexit_p() still being there:
> >
> > drivers/tty/serial/xilinx_uartps.c:1000:12: error: 'xuartps_remove' defined but not used [-Werror=unused-function]
> > drivers/usb/gadget/mv_udc_core.c:2131:12: error: 'mv_udc_remove' defined but not used [-Werror=unused-function]
>
> What platform has -Werror=unused-function set?
My test script to check if any new warnings have come in sets -Werror.
I have a git branch that has workarounds for all known gcc warnings on ARM, so
one of my tests after merging stuff is to pull that one into my for-next branch
and build all defconfigs and all{yes,no,mod}config.
Arnd
[email protected] writes:
>
> On Mon, Nov 26, 2012 at 08:38:32PM +0000, Arnd Bergmann wrote:
> > This is probably known and fixed already, but in case it's not, let me just
> > mention that I saw two new warnings with ARM allyesconfig about a
> > __devexit being removed but the __devexit_p() still being there:
> >
> > drivers/tty/serial/xilinx_uartps.c:1000:12: error: 'xuartps_remove' defined but not used [-Werror=unused-function]
> > drivers/usb/gadget/mv_udc_core.c:2131:12: error: 'mv_udc_remove' defined but not used [-Werror=unused-function]
>
> What platform has -Werror=unused-function set?
>
> Bill, care to send follow-on patches to resolve these warnings?
>
I don't understand how my changes would causing the warning. Both
functions are put in the platform_driver struct using __exit_p, not
__devexit_p. It seems like you should get the warning with or without
my changes as long as MODULE is not defined.
--
Bill