2012-11-27 20:32:48

by Aristeu Rozanski

Subject: [PATCH 1/5] device_cgroup: fix locking in devcgroup_destroy()

Cc: Tejun Heo <[email protected]>
Cc: Serge Hallyn <[email protected]>
Signed-off-by: Aristeu Rozanski <[email protected]>
---
security/device_cgroup.c | 4 ++++
1 file changed, 4 insertions(+)

Index: github/security/device_cgroup.c
===================================================================
--- github.orig/security/device_cgroup.c 2012-11-26 17:13:54.008153189 -0500
+++ github/security/device_cgroup.c 2012-11-27 11:58:43.574251075 -0500
@@ -215,7 +215,11 @@
struct dev_cgroup *dev_cgroup;

dev_cgroup = cgroup_to_devcgroup(cgroup);
+
+ mutex_lock(&devcgroup_mutex);
dev_exception_clean(dev_cgroup);
+ mutex_unlock(&devcgroup_mutex);
+
kfree(dev_cgroup);
}

2012-11-29 19:02:00

by Serge E. Hallyn

Subject: Re: [PATCH 1/5] device_cgroup: fix locking in devcgroup_destroy()

Quoting Aristeu Rozanski ([email protected]):
> Cc: Tejun Heo <[email protected]>
> Cc: Serge Hallyn <[email protected]>

Acked-by: Serge Hallyn <[email protected]>

> Signed-off-by: Aristeu Rozanski <[email protected]>
> ---
> security/device_cgroup.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> Index: github/security/device_cgroup.c
> ===================================================================
> --- github.orig/security/device_cgroup.c 2012-11-26 17:13:54.008153189 -0500
> +++ github/security/device_cgroup.c 2012-11-27 11:58:43.574251075 -0500
> @@ -215,7 +215,11 @@
> struct dev_cgroup *dev_cgroup;
>
> dev_cgroup = cgroup_to_devcgroup(cgroup);
> +
> + mutex_lock(&devcgroup_mutex);
> dev_exception_clean(dev_cgroup);
> + mutex_unlock(&devcgroup_mutex);
> +
> kfree(dev_cgroup);
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/