2012-11-29 11:21:22

by Laurent Navet

Subject: [PATCH] staging: line6: Fix checkpatch.pl switch - case issue

From: "Laurent Navet [Mali]" <[email protected]>

delete old commentted code to avoid this checkpatch error :
line6/pcm.c:423: ERROR: switch and case should be at the same indent

Signed-off-by: Laurent Navet [Mali] <[email protected]>
---
drivers/staging/line6/pcm.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index 6c1e313..a0ce781 100644
--- a/drivers/staging/line6/pcm.c
+++ b/drivers/staging/line6/pcm.c
@@ -455,14 +455,6 @@ int line6_init_pcm(struct usb_line6 *line6,
ep_write = 0x01;
break;

- /* this is for interface_number == 1:
- case LINE6_DEVID_TONEPORT_UX2:
- case LINE6_DEVID_PODSTUDIO_UX2:
- ep_read = 0x87;
- ep_write = 0x00;
- break;
- */
-
default:
MISSING_CASE;
}
--
1.7.10.4

2012-11-30 02:08:53

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: line6: Fix checkpatch.pl switch - case issue

On Thu, Nov 29, 2012 at 12:21:22PM +0100, Laurent Navet [Mali] wrote:
> From: "Laurent Navet [Mali]" <[email protected]>
>
> delete old commentted code to avoid this checkpatch error :
> line6/pcm.c:423: ERROR: switch and case should be at the same indent
>
> Signed-off-by: Laurent Navet [Mali] <[email protected]>

What is the [Mali] thing for?

> ---
> drivers/staging/line6/pcm.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
> index 6c1e313..a0ce781 100644
> --- a/drivers/staging/line6/pcm.c
> +++ b/drivers/staging/line6/pcm.c
> @@ -455,14 +455,6 @@ int line6_init_pcm(struct usb_line6 *line6,
> ep_write = 0x01;
> break;
>
> - /* this is for interface_number == 1:
> - case LINE6_DEVID_TONEPORT_UX2:
> - case LINE6_DEVID_PODSTUDIO_UX2:
> - ep_read = 0x87;
> - ep_write = 0x00;
> - break;
> - */

Why not properly indent it to keep the comment around instead?

thanks,

greg k-h

2012-11-30 20:36:15

by Laurent Navet

Subject: Re: [PATCH] staging: line6: Fix checkpatch.pl switch - case issue

> 2012/11/30, Greg KH <[email protected]>:
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list. I'll be glad to respond if you
> resend it to everyone.

Sorry, seem's i've reply instead of reply to all.
Anyway, it's maybe not the better idea i've had this day, but i've
started a new thread with a new patch[1], aggregating the two first
ones [2][3].

[1] http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033700.html

[2] http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033607.html

[3] http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033629.html

Regards,
Laurent.