2012-11-30 11:59:08

by Lars Marowsky-Bree

[permalink] [raw]
Subject: Re: [dm-devel] [PATCH 2/3] dm raid1: add interface to set resync speed

On 2012-11-22T14:27:52, Guangliang Zhao <[email protected]> wrote:

Hi Guangliang,

thanks for adding this. I think this approach is a good direction to
take, just one feedback:

> Add ioctl to control resync speed, userspace tool
> is dmsetup message, message format is:
> dmsetup message $device 0 "set $speed"
> e.g.
> dmsetup message /dev/dm-2 "set 12345"

I think this should be "set-max-resync-rate" or something; "set" is very
generic and not very extensible going forward, should the need arise.

Regards,
Lars

--
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer, HRB 21284 (AG N?rnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde