2013-03-05 02:12:38

by Youquan Song

[permalink] [raw]
Subject: Re: [PATCH v3] ata: Fix DVD not dectected at some Haswell platforms

Hi Maintainer,

Can you take the patch which is needed by some new platforms?

Thanks
-Youquan

On Mon, Feb 18, 2013 at 11:00:55AM -0500, Youquan Song wrote:
> There is a quirk patch 5e5a4f5d5a08c9c504fe956391ac3dae2c66556d
> "ata_piix: make DVD Drive recognisable on systems with Intel Sandybridge
> chipsets(v2)" fixing the 4 ports IDE controller 32bit PIO mode.
>
> We've hit a problem with DVD not recognized on Haswell Desktop platform which
> includes Lynx Point 2-port SATA controller.
>
> This quirk patch disables 32bit PIO on this controller in IDE mode.
>
> v2: Change spelling error in statememnt pointed by Sergei Shtylyov.
> v3: Change comment statememnt and spliting line over 80 characters pointed by
> Libor Pechacek and also rebase the patch against 3.8-rc7 kernel.
>
> Tested-by: Lee, Chun-Yi <[email protected]>
> Signed-off-by: Youquan Song <[email protected]>
> Cc: [email protected]
> ---
> drivers/ata/ata_piix.c | 14 +++++++++++++-
> 1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index 174eca6..4aab550 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -150,6 +150,7 @@ enum piix_controller_ids {
> tolapai_sata,
> piix_pata_vmw, /* PIIX4 for VMware, spurious DMA_ERR */
> ich8_sata_snb,
> + ich8_2port_sata_snb,
> };
>
> struct piix_map_db {
> @@ -304,7 +305,7 @@ static const struct pci_device_id piix_pci_tbl[] = {
> /* SATA Controller IDE (Lynx Point) */
> { 0x8086, 0x8c01, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata_snb },
> /* SATA Controller IDE (Lynx Point) */
> - { 0x8086, 0x8c08, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
> + { 0x8086, 0x8c08, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata_snb },
> /* SATA Controller IDE (Lynx Point) */
> { 0x8086, 0x8c09, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_2port_sata },
> /* SATA Controller IDE (Lynx Point-LP) */
> @@ -422,6 +423,7 @@ static const struct piix_map_db *piix_map_db_table[] = {
> [ich8m_apple_sata] = &ich8m_apple_map_db,
> [tolapai_sata] = &tolapai_map_db,
> [ich8_sata_snb] = &ich8_map_db,
> + [ich8_2port_sata_snb] = &ich8_2port_map_db,
> };
>
> static struct pci_bits piix_enable_bits[] = {
> @@ -1225,6 +1227,16 @@ static struct ata_port_info piix_port_info[] = {
> .udma_mask = ATA_UDMA6,
> .port_ops = &piix_sata_ops,
> },
> +
> + [ich8_2port_sata_snb] =
> + {
> + .flags = PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR
> + | PIIX_FLAG_PIO16,
> + .pio_mask = ATA_PIO4,
> + .mwdma_mask = ATA_MWDMA2,
> + .udma_mask = ATA_UDMA6,
> + .port_ops = &piix_sata_ops,
> + },
> };
>
> #define AHCI_PCI_BAR 5
> --
> 1.7.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


2013-03-05 10:25:18

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH v3] ata: Fix DVD not dectected at some Haswell platforms

On Tue, Mar 05, 2013 at 09:21:14AM -0500, Youquan Song wrote:
> Hi Maintainer,
>
> Can you take the patch which is needed by some new platforms?

I think you've got the wrong guy. Here's how you can find out who the
maintainer is:

So your patch is against drivers/ata/ata_piix.c. So you do:

$ ./scripts/get_maintainer.pl -f drivers/ata/ata_piix.c
Jeff Garzik <[email protected]> (supporter:SERIAL ATA (SATA)...)
[email protected] (open list:SERIAL ATA (SATA)...)
[email protected] (open list)

And this is the CC list you can use to send the patch to.

HTH.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--