2013-03-12 09:02:25

by Ananth N Mavinakayanahalli

Subject: [PATCH] Fix segfault in perf probe

From: Ananth N Mavinakayanahalli <[email protected]>

Fix segfault in perf probe due to a bug introduced by commit d8639f068
(perf tools: Stop using 'self' in strlist).


Signed-off-by: Ananth N Mavinakayanahalli <[email protected]>

---
Index: linus/tools/perf/util/strlist.c
===================================================================
--- linus.orig/tools/perf/util/strlist.c
+++ linus/tools/perf/util/strlist.c
@@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr
slist->rblist.node_delete = strlist__node_delete;

slist->dupstr = dupstr;
- if (slist && strlist__parse_list(slist, list) != 0)
+ if (list && strlist__parse_list(slist, list) != 0)
goto out_error;
}

2013-03-12 09:50:49

by Srikar Dronamraju

Subject: Re: [PATCH] Fix segfault in perf probe

* Ananth N Mavinakayanahalli <[email protected]> [2013-03-12 14:32:17]:

> From: Ananth N Mavinakayanahalli <[email protected]>
>
> Fix segfault in perf probe due to a bug introduced by commit d8639f068
> (perf tools: Stop using 'self' in strlist).
>
>
> Signed-off-by: Ananth N Mavinakayanahalli <[email protected]>

Acked-by: Srikar Dronamraju <[email protected]>

>
> ---
> Index: linus/tools/perf/util/strlist.c
> ===================================================================
> --- linus.orig/tools/perf/util/strlist.c
> +++ linus/tools/perf/util/strlist.c
> @@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr
> slist->rblist.node_delete = strlist__node_delete;
>
> slist->dupstr = dupstr;
> - if (slist && strlist__parse_list(slist, list) != 0)
> + if (list && strlist__parse_list(slist, list) != 0)
> goto out_error;
> }
>

--
Thanks and Regards
Srikar Dronamraju

2013-03-18 10:57:23

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf probe: Fix segfault

Commit-ID: 79146a69c8bc3f28e51c5267633abc6babf47a31
Gitweb: http://git.kernel.org/tip/79146a69c8bc3f28e51c5267633abc6babf47a31
Author: Ananth N Mavinakayanahalli <[email protected]>
AuthorDate: Tue, 12 Mar 2013 14:32:17 +0530
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 13 Mar 2013 17:00:33 -0300

perf probe: Fix segfault

Fix segfault in perf probe due to a bug introduced by commit d8639f068
(perf tools: Stop using 'self' in strlist).

Signed-off-by: Ananth N Mavinakayanahalli <[email protected]>
Acked-by: Srikar Dronamraju <[email protected]>
Cc: Srikar Dronamraju <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/strlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/strlist.c b/tools/perf/util/strlist.c
index 55433aa..eabdce0 100644
--- a/tools/perf/util/strlist.c
+++ b/tools/perf/util/strlist.c
@@ -143,7 +143,7 @@ struct strlist *strlist__new(bool dupstr, const char *list)
slist->rblist.node_delete = strlist__node_delete;

slist->dupstr = dupstr;
- if (slist && strlist__parse_list(slist, list) != 0)
+ if (list && strlist__parse_list(slist, list) != 0)
goto out_error;
}