2013-03-15 22:20:41

by Hartley Sweeten

Subject: [PATCH] video: ep93xx_fb: include <linux/io.h> for devm_ioremap()

commit be867814 "drivers/video/ep93xx-fb.c: use devm_ functions"

Introduced a build error:

drivers/video/ep93xx-fb.c: In function 'ep93xxfb_probe':
drivers/video/ep93xx-fb.c:532: error: implicit declaration of function 'devm_ioremap'
drivers/video/ep93xx-fb.c:533: warning: assignment makes pointer from integer without a cast

Include <linux/io.h> to pickup the declaration of 'devm_ioremap'.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: <[email protected]>
Cc: Florian Tobias Schandinat <[email protected]>
Cc: Ryan Mallon <[email protected]>
Cc: Damien Cassou <[email protected]>

---
drivers/video/ep93xx-fb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c
index 3f2519d..e06cd5d 100644
--- a/drivers/video/ep93xx-fb.c
+++ b/drivers/video/ep93xx-fb.c
@@ -23,6 +23,7 @@
#include <linux/slab.h>
#include <linux/clk.h>
#include <linux/fb.h>
+#include <linux/io.h>

#include <linux/platform_data/video-ep93xx.h>

--
1.8.1.4

2013-03-15 22:24:18

by Ryan Mallon

Subject: Re: [PATCH] video: ep93xx_fb: include <linux/io.h> for devm_ioremap()

On 16/03/13 09:20, H Hartley Sweeten wrote:

> commit be867814 "drivers/video/ep93xx-fb.c: use devm_ functions"
>
> Introduced a build error:
>
> drivers/video/ep93xx-fb.c: In function 'ep93xxfb_probe':
> drivers/video/ep93xx-fb.c:532: error: implicit declaration of function 'devm_ioremap'
> drivers/video/ep93xx-fb.c:533: warning: assignment makes pointer from integer without a cast
>
> Include <linux/io.h> to pickup the declaration of 'devm_ioremap'.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: <[email protected]>
> Cc: Florian Tobias Schandinat <[email protected]>
> Cc: Ryan Mallon <[email protected]>
> Cc: Damien Cassou <[email protected]>

Acked-by: Ryan Mallon <[email protected]>

> ---
> drivers/video/ep93xx-fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/ep93xx-fb.c b/drivers/video/ep93xx-fb.c
> index 3f2519d..e06cd5d 100644
> --- a/drivers/video/ep93xx-fb.c
> +++ b/drivers/video/ep93xx-fb.c
> @@ -23,6 +23,7 @@
> #include <linux/slab.h>
> #include <linux/clk.h>
> #include <linux/fb.h>
> +#include <linux/io.h>
>
> #include <linux/platform_data/video-ep93xx.h>
>