2013-03-14 21:57:05

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove

4740f73fe5 "mfd: remove use of __devexit" removed the __devexit annotation
on the twl4030_madc_remove function, but left an __exit_p() present on the
pointer to this function. Using __exit_p was as wrong with the devexit in
place as it is now, but now we get a gcc warning about an unused function.

In order for the twl4030_madc_remove to work correctly in built-in code, we
have to remove the __exit_p.

Cc: Bill Pemberton <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
---

Please apply to MFD tree for 3.9

drivers/mfd/twl4030-madc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
index 88ff9dc..942b666 100644
--- a/drivers/mfd/twl4030-madc.c
+++ b/drivers/mfd/twl4030-madc.c
@@ -800,7 +800,7 @@ static int twl4030_madc_remove(struct platform_device *pdev)

static struct platform_driver twl4030_madc_driver = {
.probe = twl4030_madc_probe,
- .remove = __exit_p(twl4030_madc_remove),
+ .remove = twl4030_madc_remove,
.driver = {
.name = "twl4030_madc",
.owner = THIS_MODULE,
--
1.8.1.2


2013-03-14 21:56:59

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet
driver depends on this deprecated functionality but is not
marked so in Kconfig.

Rather than adding ARM to the already long list of architectures
that this driver is broken on, this patch adds 'depends on
VIRT_TO_BUS' and removes the dependency on !SPARC, which is
also implied by that.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Karsten Keil <[email protected]>
Cc: [email protected]
---
Please apply for 3.9 or 3.10, this one is not urgent

drivers/isdn/hisax/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
index 5313c9e..d9edcc9 100644
--- a/drivers/isdn/hisax/Kconfig
+++ b/drivers/isdn/hisax/Kconfig
@@ -237,7 +237,8 @@ config HISAX_MIC

config HISAX_NETJET
bool "NETjet card"
- depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on VIRT_TO_BUS
help
This enables HiSax support for the NetJet from Traverse
Technologies.
@@ -248,7 +249,8 @@ config HISAX_NETJET

config HISAX_NETJET_U
bool "NETspider U card"
- depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
+ depends on VIRT_TO_BUS
help
This enables HiSax support for the Netspider U interface ISDN card
from Traverse Technologies.
--
1.8.1.2

2013-03-14 21:57:34

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] ethernet/tulip: DE4x5 needs VIRT_TO_BUS

The automated ARM build tests have shown that the tulip de4x5 driver
uses the old-style virt_to_bus() interface on some architectures.

Alpha, Sparc and PowerPC did not hit this problem, because they
use a different code path, and most other architectures actually
do provide VIRT_TO_BUS.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Grant Grundler <[email protected]>
Cc: [email protected]
---
Please apply for 3.9 or 3.10, this one is not urgent

drivers/net/ethernet/dec/tulip/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/dec/tulip/Kconfig b/drivers/net/ethernet/dec/tulip/Kconfig
index 0c37fb2..1df33c7 100644
--- a/drivers/net/ethernet/dec/tulip/Kconfig
+++ b/drivers/net/ethernet/dec/tulip/Kconfig
@@ -108,6 +108,7 @@ config TULIP_DM910X
config DE4X5
tristate "Generic DECchip & DIGITAL EtherWORKS PCI/EISA"
depends on (PCI || EISA)
+ depends on VIRT_TO_BUS || ALPHA || PPC || SPARC
select CRC32
---help---
This is support for the DIGITAL series of PCI/EISA Ethernet cards.
--
1.8.1.2

2013-03-14 21:56:58

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] [media] ir: IR_RX51 only works on OMAP2

This driver can be enabled on OMAP1 at the moment, which breaks
allyesconfig for that platform. Let's mark it OMAP2PLUS-only
in Kconfig, since that is the only thing it builds on.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Timo Kokkonen <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: [email protected]
---
Mauro, please apply for 3.9

drivers/media/rc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
index 19f3563..5a79c33 100644
--- a/drivers/media/rc/Kconfig
+++ b/drivers/media/rc/Kconfig
@@ -291,7 +291,7 @@ config IR_TTUSBIR

config IR_RX51
tristate "Nokia N900 IR transmitter diode"
- depends on OMAP_DM_TIMER && LIRC && !ARCH_MULTIPLATFORM
+ depends on OMAP_DM_TIMER && ARCH_OMAP2PLUS && LIRC && !ARCH_MULTIPLATFORM
---help---
Say Y or M here if you want to enable support for the IR
transmitter diode built in the Nokia N900 (RX51) device.
--
1.8.1.2

2013-03-14 21:56:55

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] vfio: include <linux/slab.h> for kmalloc

The vfio drivers call kmalloc or kzalloc, but do not
include <linux/slab.h>, which causes build errors on
ARM.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Alex Williamson <[email protected]>
Cc: [email protected]
---
Please apply for 3.9

drivers/vfio/pci/vfio_pci_config.c | 1 +
drivers/vfio/pci/vfio_pci_intrs.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
index 964ff22..aeb00fc 100644
--- a/drivers/vfio/pci/vfio_pci_config.c
+++ b/drivers/vfio/pci/vfio_pci_config.c
@@ -27,6 +27,7 @@
#include <linux/pci.h>
#include <linux/uaccess.h>
#include <linux/vfio.h>
+#include <linux/slab.h>

#include "vfio_pci_private.h"

diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index 3639371..a965091 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -22,6 +22,7 @@
#include <linux/vfio.h>
#include <linux/wait.h>
#include <linux/workqueue.h>
+#include <linux/slab.h>

#include "vfio_pci_private.h"

--
1.8.1.2

2013-03-14 21:58:18

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH 3/3] mfd: ab8500: kill "reg" property from binding

The ab8500 device is a child of the prcmu device, which is a memory mapped
bus device, whose children are addressable using physical memory addresses,
not using mailboxes, so a mailbox number in the ab8500 node cannot be
parsed by DT. Nothing uses this number, since it was only introduced
as part of the failed attempt to clean up prcmu mailbox handling, and
we can simply remove it.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Acked-by: Lee Jones <[email protected]>
---
Please apply to MFD tree for 3.9


Documentation/devicetree/bindings/mfd/ab8500.txt | 6 +-----
arch/arm/boot/dts/dbx5x0.dtsi | 3 +--
arch/arm/boot/dts/href.dtsi | 2 +-
arch/arm/boot/dts/hrefv60plus.dts | 2 +-
arch/arm/boot/dts/snowball.dts | 2 +-
5 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/ab8500.txt b/Documentation/devicetree/bindings/mfd/ab8500.txt
index 13b707b..c3a14e0 100644
--- a/Documentation/devicetree/bindings/mfd/ab8500.txt
+++ b/Documentation/devicetree/bindings/mfd/ab8500.txt
@@ -13,9 +13,6 @@ Required parent device properties:
4 = active high level-sensitive
8 = active low level-sensitive

-Optional parent device properties:
-- reg : contains the PRCMU mailbox address for the AB8500 i2c port
-
The AB8500 consists of a large and varied group of sub-devices:

Device IRQ Names Supply Names Description
@@ -86,9 +83,8 @@ Non-standard child device properties:
- stericsson,amic2-bias-vamic1 : Analoge Mic wishes to use a non-standard Vamic
- stericsson,earpeice-cmv : Earpeice voltage (only: 950 | 1100 | 1270 | 1580)

-ab8500@5 {
+ab8500 {
compatible = "stericsson,ab8500";
- reg = <5>; /* mailbox 5 is i2c */
interrupts = <0 40 0x4>;
interrupt-controller;
#interrupt-cells = <2>;
diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index 69140ba..9de9309 100644
--- a/arch/arm/boot/dts/dbx5x0.dtsi
+++ b/arch/arm/boot/dts/dbx5x0.dtsi
@@ -319,9 +319,8 @@
};
};

- ab8500@5 {
+ ab8500 {
compatible = "stericsson,ab8500";
- reg = <5>; /* mailbox 5 is i2c */
interrupt-parent = <&intc>;
interrupts = <0 40 0x4>;
interrupt-controller;
diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
index 592fb9d..379128e 100644
--- a/arch/arm/boot/dts/href.dtsi
+++ b/arch/arm/boot/dts/href.dtsi
@@ -221,7 +221,7 @@
};
};

- ab8500@5 {
+ ab8500 {
ab8500-regulators {
ab8500_ldo_aux1_reg: ab8500_ldo_aux1 {
regulator-name = "V-DISPLAY";
diff --git a/arch/arm/boot/dts/hrefv60plus.dts b/arch/arm/boot/dts/hrefv60plus.dts
index 55f4191..2b587a7 100644
--- a/arch/arm/boot/dts/hrefv60plus.dts
+++ b/arch/arm/boot/dts/hrefv60plus.dts
@@ -158,7 +158,7 @@
};
};

- ab8500@5 {
+ ab8500 {
ab8500-regulators {
ab8500_ldo_aux1_reg: ab8500_ldo_aux1 {
regulator-name = "V-DISPLAY";
diff --git a/arch/arm/boot/dts/snowball.dts b/arch/arm/boot/dts/snowball.dts
index 27f31a5..d3ec32f 100644
--- a/arch/arm/boot/dts/snowball.dts
+++ b/arch/arm/boot/dts/snowball.dts
@@ -298,7 +298,7 @@
};
};

- ab8500@5 {
+ ab8500 {
ab8500-regulators {
ab8500_ldo_aux1_reg: ab8500_ldo_aux1 {
regulator-name = "V-DISPLAY";
--
1.8.1.2

2013-03-14 21:56:53

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH 2/3] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error

From: Axel Lin <[email protected]>

This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.

drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
make: *** [vmlinux] Error 1

Signed-off-by: Axel Lin <[email protected]>
Acked-by: Lee Jones <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
---
Please apply to MFD tree for 3.9

drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 671f5b1..c346941 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -858,6 +858,7 @@ config EZX_PCAP
config AB8500_CORE
bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
+ select POWER_SUPPLY
select MFD_CORE
select IRQ_DOMAIN
help
--
1.8.1.2

2013-03-15 06:26:37

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

On Thu, Mar 14, 2013 at 10:56 PM, Arnd Bergmann <[email protected]> wrote:
> Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet
> driver depends on this deprecated functionality but is not
> marked so in Kconfig.
>
> Rather than adding ARM to the already long list of architectures
> that this driver is broken on, this patch adds 'depends on
> VIRT_TO_BUS' and removes the dependency on !SPARC, which is
> also implied by that.

IIRC, the real "arch" dependency for this driver is !BIG_ENDIAN, but
unfortunately
we don't have a generic Kconfig symbol for that.
Perhaps we may want to introduce that?
Of course we prefer to make drivers work on all endianness instead...

> --- a/drivers/isdn/hisax/Kconfig
> +++ b/drivers/isdn/hisax/Kconfig
> @@ -237,7 +237,8 @@ config HISAX_MIC
>
> config HISAX_NETJET
> bool "NETjet card"
> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> + depends on VIRT_TO_BUS
> help
> This enables HiSax support for the NetJet from Traverse
> Technologies.
> @@ -248,7 +249,8 @@ config HISAX_NETJET
>
> config HISAX_NETJET_U
> bool "NETspider U card"
> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> + depends on PCI && (BROKEN || !(PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> + depends on VIRT_TO_BUS

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2013-03-15 06:39:19

by Timo Kokkonen

[permalink] [raw]
Subject: Re: [PATCH] [media] ir: IR_RX51 only works on OMAP2

On 03.14 2013 22:56:44, Arnd Bergmann wrote:
> This driver can be enabled on OMAP1 at the moment, which breaks
> allyesconfig for that platform. Let's mark it OMAP2PLUS-only
> in Kconfig, since that is the only thing it builds on.
>

Acked-by: Timo Kokkonen <[email protected]>

Thanks!

> Signed-off-by: Arnd Bergmann <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Timo Kokkonen <[email protected]>
> Cc: Tony Lindgren <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: [email protected]
> ---
> Mauro, please apply for 3.9
>
> drivers/media/rc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig
> index 19f3563..5a79c33 100644
> --- a/drivers/media/rc/Kconfig
> +++ b/drivers/media/rc/Kconfig
> @@ -291,7 +291,7 @@ config IR_TTUSBIR
>
> config IR_RX51
> tristate "Nokia N900 IR transmitter diode"
> - depends on OMAP_DM_TIMER && LIRC && !ARCH_MULTIPLATFORM
> + depends on OMAP_DM_TIMER && ARCH_OMAP2PLUS && LIRC && !ARCH_MULTIPLATFORM
> ---help---
> Say Y or M here if you want to enable support for the IR
> transmitter diode built in the Nokia N900 (RX51) device.
> --
> 1.8.1.2
>

2013-03-15 06:44:36

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH 1/3] mfd: remove __exit_p annotation for twl4030_madc_remove

Hi Arnd,

On Thu, Mar 14, 2013 at 10:56:38PM +0100, Arnd Bergmann wrote:
> 4740f73fe5 "mfd: remove use of __devexit" removed the __devexit annotation
> on the twl4030_madc_remove function, but left an __exit_p() present on the
> pointer to this function. Using __exit_p was as wrong with the devexit in
> place as it is now, but now we get a gcc warning about an unused function.
>
> In order for the twl4030_madc_remove to work correctly in built-in code, we
> have to remove the __exit_p.
>
> Cc: Bill Pemberton <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Samuel Ortiz <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
>
> Please apply to MFD tree for 3.9
>
> drivers/mfd/twl4030-madc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to mfd-fixes.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2013-03-15 06:45:22

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH 2/3] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error

Hi Arnd,

On Thu, Mar 14, 2013 at 10:56:39PM +0100, Arnd Bergmann wrote:
> From: Axel Lin <[email protected]>
>
> This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.
>
> drivers/built-in.o: In function `ab8500_power_off':
> drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
> drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <[email protected]>
> Acked-by: Lee Jones <[email protected]>
> Cc: Samuel Ortiz <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> Please apply to MFD tree for 3.9
Already applied to mfd-fixes.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2013-03-15 06:46:00

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH 3/3] mfd: ab8500: kill "reg" property from binding

Hi Arnd,

On Thu, Mar 14, 2013 at 10:56:40PM +0100, Arnd Bergmann wrote:
> The ab8500 device is a child of the prcmu device, which is a memory mapped
> bus device, whose children are addressable using physical memory addresses,
> not using mailboxes, so a mailbox number in the ab8500 node cannot be
> parsed by DT. Nothing uses this number, since it was only introduced
> as part of the failed attempt to clean up prcmu mailbox handling, and
> we can simply remove it.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Cc: Samuel Ortiz <[email protected]>
> Acked-by: Lee Jones <[email protected]>
> ---
> Please apply to MFD tree for 3.9
Already applied to mfd-fixes.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2013-03-15 10:15:14

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

On Friday 15 March 2013, Geert Uytterhoeven wrote:
> On Thu, Mar 14, 2013 at 10:56 PM, Arnd Bergmann <[email protected]> wrote:
> > Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet
> > driver depends on this deprecated functionality but is not
> > marked so in Kconfig.
> >
> > Rather than adding ARM to the already long list of architectures
> > that this driver is broken on, this patch adds 'depends on
> > VIRT_TO_BUS' and removes the dependency on !SPARC, which is
> > also implied by that.
>
> IIRC, the real "arch" dependency for this driver is !BIG_ENDIAN, but
> unfortunately
> we don't have a generic Kconfig symbol for that.
> Perhaps we may want to introduce that?
> Of course we prefer to make drivers work on all endianness instead...

CONFIG_VIRT_TO_BUS is certainly also a dependency, since it fails
to build without that. I think we can address the two problems separately.

David Howells brought up the topic of endian checks recently, noting
that the way we define __BIG_ENDIAN and __LITTLE_ENDIAN in the kernel
is incompatible to how do it in user space, and not much better either.

A few architectures that are bi-endian (arc, arm, c6x, mips, sh) already
have CONFIG_CPU_IS_LITTLE_ENDIAN and CONFIG_CPU_IS_BIG_ENDIAN. I guess
it would be a good idea to provide these on all architectures.

Arnd

2013-03-15 10:18:19

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH 2/3] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error

On Friday 15 March 2013, Samuel Ortiz wrote:
> On Thu, Mar 14, 2013 at 10:56:39PM +0100, Arnd Bergmann wrote:
> >
> > Please apply to MFD tree for 3.9
> Already applied to mfd-fixes.
>

For some reason I did not see it when I rebased my patches on top of linux-next
to make sure I don't send any patches again that are already queued up.

Is there a reason why mfd-fixes is not part of linux-next?

Arnd

2013-03-15 12:16:45

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

From: Arnd Bergmann <[email protected]>
Date: Fri, 15 Mar 2013 10:15:00 +0000

> David Howells brought up the topic of endian checks recently, noting
> that the way we define __BIG_ENDIAN and __LITTLE_ENDIAN in the kernel
> is incompatible to how do it in user space, and not much better either.
>
> A few architectures that are bi-endian (arc, arm, c6x, mips, sh) already
> have CONFIG_CPU_IS_LITTLE_ENDIAN and CONFIG_CPU_IS_BIG_ENDIAN. I guess
> it would be a good idea to provide these on all architectures.

I do not want to see us add such a Kconfig dependency knob.

Then the real tendency will exist to make new drivers little-endian
only, refuse to fix endian-broken old drivers, etc.

Which means that allmodconfig on my architecture will have build
coverage on less code, which is really the only thing that matters
for me. I want all drivers that could be effected by my changes
to be compile testable on as many platforms as possible.

2013-03-15 12:30:17

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

On Friday 15 March 2013, David Miller wrote:
> I do not want to see us add such a Kconfig dependency knob.
>
> Then the real tendency will exist to make new drivers little-endian
> only, refuse to fix endian-broken old drivers, etc.
>
> Which means that allmodconfig on my architecture will have build
> coverage on less code, which is really the only thing that matters
> for me. I want all drivers that could be effected by my changes
> to be compile testable on as many platforms as possible.

There are two separate issues here. The first one that David Howells
brought up was ill-defined __BIG_ENDIAN/__LITTLE_ENDIAN macros.
Using CONFIG_CPU_IS_BIG_ENDIAN/CONFIG_CPU_IS_LITTLE_ENDIAN in the code
is what Linus suggested as a replacement, although I see little
incentive to do mass conversion there, it would be mainly for new
code.

The other issue is the Kconfig logic where Geert would replace
all the instances of "depends on BROKEN || !(SPARC || PPC || PARISC ||
M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA &&
!CPU_LITTLE_ENDIAN))" with something that actually reflects what
we mean. I think it would be a nice cleanup, but I can also understand
your hesitation there.

Do you object to both uses of that symbol, or just to using it in order
to disable drivers in Kconfig? I don't care too much right now, since
nothing is actually broken at the moment, I would just like to get
the VIRT_TO_BUS patch merged so people can also build allmodconfig
on my architecture ;-)

Arnd

2013-03-15 12:33:43

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

From: Arnd Bergmann <[email protected]>
Date: Fri, 15 Mar 2013 12:29:52 +0000

> On Friday 15 March 2013, David Miller wrote:
>> I do not want to see us add such a Kconfig dependency knob.
>>
>> Then the real tendency will exist to make new drivers little-endian
>> only, refuse to fix endian-broken old drivers, etc.
>>
>> Which means that allmodconfig on my architecture will have build
>> coverage on less code, which is really the only thing that matters
>> for me. I want all drivers that could be effected by my changes
>> to be compile testable on as many platforms as possible.
>
> There are two separate issues here. The first one that David Howells
> brought up was ill-defined __BIG_ENDIAN/__LITTLE_ENDIAN macros.
> Using CONFIG_CPU_IS_BIG_ENDIAN/CONFIG_CPU_IS_LITTLE_ENDIAN in the code
> is what Linus suggested as a replacement, although I see little
> incentive to do mass conversion there, it would be mainly for new
> code.
>
> The other issue is the Kconfig logic where Geert would replace
> all the instances of "depends on BROKEN || !(SPARC || PPC || PARISC ||
> M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA &&
> !CPU_LITTLE_ENDIAN))" with something that actually reflects what
> we mean. I think it would be a nice cleanup, but I can also understand
> your hesitation there.
>
> Do you object to both uses of that symbol, or just to using it in order
> to disable drivers in Kconfig? I don't care too much right now, since
> nothing is actually broken at the moment, I would just like to get
> the VIRT_TO_BUS patch merged so people can also build allmodconfig
> on my architecture ;-)

The first usage seems reason, but the temtation is going to be quite
strong to misuse to block out drivers when there is "no value" in
spending time necessary to simply make them endian clean instead.

2013-03-15 13:41:24

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

On Friday 15 March 2013, David Miller wrote:
> The first usage seems reason, but the temtation is going to be quite
> strong to misuse to block out drivers when there is "no value" in
> spending time necessary to simply make them endian clean instead.

Right. I'll let someone else start that discussion then if they
really want to see that patch.

Arnd

2013-03-15 16:28:45

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] [media] ir: IR_RX51 only works on OMAP2

* Timo Kokkonen <[email protected]> [130314 23:43]:
> On 03.14 2013 22:56:44, Arnd Bergmann wrote:
> > This driver can be enabled on OMAP1 at the moment, which breaks
> > allyesconfig for that platform. Let's mark it OMAP2PLUS-only
> > in Kconfig, since that is the only thing it builds on.
> >
>
> Acked-by: Timo Kokkonen <[email protected]>

Acked-by: Tony Lindgren <[email protected]>

2013-03-15 16:47:40

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH 2/3] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error

Hi Arnd,

On Fri, Mar 15, 2013 at 10:18:13AM +0000, Arnd Bergmann wrote:
> On Friday 15 March 2013, Samuel Ortiz wrote:
> > On Thu, Mar 14, 2013 at 10:56:39PM +0100, Arnd Bergmann wrote:
> > >
> > > Please apply to MFD tree for 3.9
> > Already applied to mfd-fixes.
> >
>
> For some reason I did not see it when I rebased my patches on top of linux-next
> to make sure I don't send any patches again that are already queued up.
>
> Is there a reason why mfd-fixes is not part of linux-next?
No valid reasons, you're right. I'll ping Stephen about it.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2013-03-15 20:15:56

by Alex Williamson

[permalink] [raw]
Subject: Re: [PATCH] vfio: include <linux/slab.h> for kmalloc

On Thu, 2013-03-14 at 22:56 +0100, Arnd Bergmann wrote:
> The vfio drivers call kmalloc or kzalloc, but do not
> include <linux/slab.h>, which causes build errors on
> ARM.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Cc: Alex Williamson <[email protected]>
> Cc: [email protected]
> ---
> Please apply for 3.9

Applied, Thanks,

Alex

> drivers/vfio/pci/vfio_pci_config.c | 1 +
> drivers/vfio/pci/vfio_pci_intrs.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
> index 964ff22..aeb00fc 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -27,6 +27,7 @@
> #include <linux/pci.h>
> #include <linux/uaccess.h>
> #include <linux/vfio.h>
> +#include <linux/slab.h>
>
> #include "vfio_pci_private.h"
>
> diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> index 3639371..a965091 100644
> --- a/drivers/vfio/pci/vfio_pci_intrs.c
> +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> @@ -22,6 +22,7 @@
> #include <linux/vfio.h>
> #include <linux/wait.h>
> #include <linux/workqueue.h>
> +#include <linux/slab.h>
>
> #include "vfio_pci_private.h"
>


2013-03-17 16:01:43

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] ethernet/tulip: DE4x5 needs VIRT_TO_BUS

From: Arnd Bergmann <[email protected]>
Date: Thu, 14 Mar 2013 22:56:42 +0100

> The automated ARM build tests have shown that the tulip de4x5 driver
> uses the old-style virt_to_bus() interface on some architectures.
>
> Alpha, Sparc and PowerPC did not hit this problem, because they
> use a different code path, and most other architectures actually
> do provide VIRT_TO_BUS.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Applied.

2013-03-17 16:01:53

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] isdn: hisax: netjet requires VIRT_TO_BUS

From: Arnd Bergmann <[email protected]>
Date: Thu, 14 Mar 2013 22:56:41 +0100

> Disabling CONFIG_VIRT_TO_BUS on ARM showed that the hisax netjet
> driver depends on this deprecated functionality but is not
> marked so in Kconfig.
>
> Rather than adding ARM to the already long list of architectures
> that this driver is broken on, this patch adds 'depends on
> VIRT_TO_BUS' and removes the dependency on !SPARC, which is
> also implied by that.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

Applied.

2013-03-18 23:54:33

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH] [media] ir: IR_RX51 only works on OMAP2

Em Thu, 14 Mar 2013 22:56:44 +0100
Arnd Bergmann <[email protected]> escreveu:

> This driver can be enabled on OMAP1 at the moment, which breaks
> allyesconfig for that platform. Let's mark it OMAP2PLUS-only
> in Kconfig, since that is the only thing it builds on.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Timo Kokkonen <[email protected]>
> Cc: Tony Lindgren <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: [email protected]
> ---
> Mauro, please apply for 3.9

OK, I'm applying it on my 3.9 branch right now.

Thanks!
Mauro