2013-03-17 21:50:47

by Christopher Li

[permalink] [raw]
Subject: [RFC PATCH] kbuild: avoid some unnecessary rebuild

In the current tip of git tree. If I do a allmodconfig full build, then follow
by a "make" again without changing any code in the tree.
There are some object will always get rebuild. e.g. eboot.o.
I use "make V=2", it shows that the rebuild is due to some object file
not in $(targets). I did not understand the $(targets) very well, the
Kbuild.include mention that It is likely a bug in the kbuild if that
happen.

I add them in the $(targets) and that seems avoid the unnecessary
rebuild of several objects. The second "make" has fewer output.
The clean rebuild seems works fine too.

Chris


Attachments:
kbuild-avoid-rebuild-some-object.patch (1.60 kB)

2013-03-17 21:58:15

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

On Sun, Mar 17, 2013 at 02:50:44PM -0700, Christopher Li wrote:
> In the current tip of git tree. If I do a allmodconfig full build, then follow
> by a "make" again without changing any code in the tree.
> There are some object will always get rebuild. e.g. eboot.o.
> I use "make V=2", it shows that the rebuild is due to some object file
> not in $(targets). I did not understand the $(targets) very well, the
> Kbuild.include mention that It is likely a bug in the kbuild if that
> happen.
>
> I add them in the $(targets) and that seems avoid the unnecessary
> rebuild of several objects. The second "make" has fewer output.
> The clean rebuild seems works fine too.

We got no patch - just some git help stuff.
Seems you mistyped somthing..

Sam

2013-03-17 22:08:13

by Christopher Li

[permalink] [raw]
Subject: Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

On Sun, Mar 17, 2013 at 2:58 PM, Sam Ravnborg <[email protected]> wrote:
>
> We got no patch - just some git help stuff.
> Seems you mistyped somthing..
>

Oops, sorry about that. I reattach the patch here.

Chris


Attachments:
kbuild-avoid-rebuild-some-object.patch (819.00 B)

2013-03-20 20:19:16

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

On Sun, Mar 17, 2013 at 03:08:11PM -0700, Christopher Li wrote:
> On Sun, Mar 17, 2013 at 2:58 PM, Sam Ravnborg <[email protected]> wrote:
> >
> > We got no patch - just some git help stuff.
> > Seems you mistyped somthing..
> >
>
> Oops, sorry about that. I reattach the patch here.

I looked at the attached patch:
Acked-by: Sam Ravnborg <[email protected]>

2013-03-21 20:05:18

by Christopher Li

[permalink] [raw]
Subject: Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

Let me add a signed off in case some one want to apply it.

Signed-Off-By: Christopher Li <[email protected]>

On Wed, Mar 20, 2013 at 1:19 PM, Sam Ravnborg <[email protected]> wrote:
> I looked at the attached patch:
> Acked-by: Sam Ravnborg <[email protected]>

2013-04-10 08:36:08

by Michal Marek

[permalink] [raw]
Subject: Re: [RFC PATCH] kbuild: avoid some unnecessary rebuild

On 17.3.2013 23:08, Christopher Li wrote:
> On Sun, Mar 17, 2013 at 2:58 PM, Sam Ravnborg <[email protected]> wrote:
>>
>> We got no patch - just some git help stuff.
>> Seems you mistyped somthing..
>>
>
> Oops, sorry about that. I reattach the patch here.

Can you send a patch that only fixes scripts/mod? The EFI_STUB rebuild
has been fixed differently in the x86 tree (where such fixes should be
sent anyway).

Thanks,
Michal