LinuxLists.cc - hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions

2013-03-21 23:47:10

Subject: hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions

Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build
error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both
CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.

drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)

Signed-off-by: Jingoo Han <[email protected]>
Reported-by: David Rientjes <[email protected]>
Cc: Herbert Xu <[email protected]>
---
drivers/char/hw_random/exynos-rng.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c
index b7e48a2..402ccfb 100644
--- a/drivers/char/hw_random/exynos-rng.c
+++ b/drivers/char/hw_random/exynos-rng.c
@@ -144,7 +144,7 @@ static int exynos_rng_remove(struct platform_device *pdev)
return 0;
}

-#ifdef CONFIG_PM_SLEEP
+#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
static int exynos_rng_runtime_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
--
1.7.2.5

2013-03-22 01:56:00

by Jingoo Han

[permalink] [raw]

Subject: [PATCH] hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions

2013-03-22 09:45:08

by David Rientjes

[permalink] [raw]

Subject: Re: [PATCH] hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions

On Fri, 22 Mar 2013, Jingoo Han wrote:

> Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build
> error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both
> CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
>
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
> drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)
>
> Signed-off-by: Jingoo Han <[email protected]>
> Reported-by: David Rientjes <[email protected]>
> Cc: Herbert Xu <[email protected]>

Acked-by: David Rientjes <[email protected]>

2013-03-22 10:15:26

by Herbert Xu

[permalink] [raw]

Subject: Re: [PATCH] hwrng: exynos - add CONFIG_PM_RUNTIME to suspend/resume functions

On Fri, Mar 22, 2013 at 02:38:53AM -0700, David Rientjes wrote:
> On Fri, 22 Mar 2013, Jingoo Han wrote:
>
> > Add CONFIG_PM_RUNTIME to suspend/resume functions to fix the build
> > error. It is because UNIVERSAL_DEV_PM_OPS macro is related to both
> > CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
> >
> > drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_suspend' undeclared here (not in a function)
> > drivers/char/hw_random/exynos-rng.c:167:8: error: 'exynos_rng_runtime_resume' undeclared here (not in a function)
> >
> > Signed-off-by: Jingoo Han <[email protected]>
> > Reported-by: David Rientjes <[email protected]>
> > Cc: Herbert Xu <[email protected]>
>
> Acked-by: David Rientjes <[email protected]>

Thanks, I've folded this into the original patch and rebased
the tree so that it is bisectable.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt