2013-03-13 09:58:40

by Sachin Kamat

Subject: [PATCH 1/1] clk: Fix incorrect return type in clk.c

Return type of function clk_propagate_rate_change is a pointer.
But 0 was being returned. Change it to NULL.
Silences the following warning:
drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/clk/clk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ed87b24..467b31f 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -974,7 +974,7 @@ static struct clk *clk_propagate_rate_change(struct clk *clk, unsigned long even
int ret = NOTIFY_DONE;

if (clk->rate == clk->new_rate)
- return 0;
+ return NULL;

if (clk->notifier_count) {
ret = __clk_notify(clk, event, clk->rate, clk->new_rate);
--
1.7.4.1

2013-03-13 17:09:21

by Pankaj Jangra

Subject: Re: [PATCH 1/1] clk: Fix incorrect return type in clk.c

Hi.

On Wed, Mar 13, 2013 at 3:17 PM, Sachin Kamat <[email protected]> wrote:
> Return type of function clk_propagate_rate_change is a pointer.
> But 0 was being returned. Change it to NULL.
> Silences the following warning:
> drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/clk/clk.c | 2 +-

Looks good to me.
Reviewed-by: Pankaj Jangra <[email protected]>

Regards,
Pankaj Jangra

2013-03-22 19:19:16

by Mike Turquette

Subject: Re: [PATCH 1/1] clk: Fix incorrect return type in clk.c

Quoting Pankaj Jangra (2013-03-13 10:09:18)
> Hi.
>
> On Wed, Mar 13, 2013 at 3:17 PM, Sachin Kamat <[email protected]> wrote:
> > Return type of function clk_propagate_rate_change is a pointer.
> > But 0 was being returned. Change it to NULL.
> > Silences the following warning:
> > drivers/clk/clk.c:977:24: warning: Using plain integer as NULL pointer
> >
> > Signed-off-by: Sachin Kamat <[email protected]>
> > ---
> > drivers/clk/clk.c | 2 +-
>
> Looks good to me.
> Reviewed-by: Pankaj Jangra <[email protected]>
>

Thanks for the fix. Taken into clk-next.

Regards,
Mike

> Regards,
> Pankaj Jangra