2013-03-26 14:55:08

by Axel Lin

[permalink] [raw]
Subject: [PATCH 1/2] pwm: tiecap: Staticize non-exported symbols

Both ecap_pwm_save_context() and ecap_pwm_restore_context() are only used in
this file, make them static.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/pwm/pwm-tiecap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index f024db0..0d65fb2 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -295,7 +295,7 @@ static int ecap_pwm_remove(struct platform_device *pdev)
return pwmchip_remove(&pc->chip);
}

-void ecap_pwm_save_context(struct ecap_pwm_chip *pc)
+static void ecap_pwm_save_context(struct ecap_pwm_chip *pc)
{
pm_runtime_get_sync(pc->chip.dev);
pc->ctx.ecctl2 = readw(pc->mmio_base + ECCTL2);
@@ -304,7 +304,7 @@ void ecap_pwm_save_context(struct ecap_pwm_chip *pc)
pm_runtime_put_sync(pc->chip.dev);
}

-void ecap_pwm_restore_context(struct ecap_pwm_chip *pc)
+static void ecap_pwm_restore_context(struct ecap_pwm_chip *pc)
{
writel(pc->ctx.cap3, pc->mmio_base + CAP3);
writel(pc->ctx.cap4, pc->mmio_base + CAP4);
--
1.7.10.4



2013-03-26 14:56:06

by Axel Lin

[permalink] [raw]
Subject: [PATCH 2/2] pwm: tiehrpwm: Staticize non-exported symbols

Both ehrpwm_pwm_save_context() and ehrpwm_pwm_restore_context() are only used in
this file, make them static.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/pwm/pwm-tiehrpwm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index d058ba9..6a21759 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -533,7 +533,7 @@ static int ehrpwm_pwm_remove(struct platform_device *pdev)
return pwmchip_remove(&pc->chip);
}

-void ehrpwm_pwm_save_context(struct ehrpwm_pwm_chip *pc)
+static void ehrpwm_pwm_save_context(struct ehrpwm_pwm_chip *pc)
{
pm_runtime_get_sync(pc->chip.dev);
pc->ctx.tbctl = ehrpwm_read(pc->mmio_base, TBCTL);
@@ -547,7 +547,7 @@ void ehrpwm_pwm_save_context(struct ehrpwm_pwm_chip *pc)
pm_runtime_put_sync(pc->chip.dev);
}

-void ehrpwm_pwm_restore_context(struct ehrpwm_pwm_chip *pc)
+static void ehrpwm_pwm_restore_context(struct ehrpwm_pwm_chip *pc)
{
ehrpwm_write(pc->mmio_base, TBPRD, pc->ctx.tbprd);
ehrpwm_write(pc->mmio_base, CMPA, pc->ctx.cmpa);
--
1.7.10.4


2013-03-26 15:24:56

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH 1/2] pwm: tiecap: Staticize non-exported symbols

On Tue, Mar 26, 2013 at 10:54:58PM +0800, Axel Lin wrote:
> Both ecap_pwm_save_context() and ecap_pwm_restore_context() are only used in
> this file, make them static.
>
> Signed-off-by: Axel Lin <[email protected]>

Applied, thanks.

Thierry

Attachments:
(No filename) (246.00 B)
 (No filename) (836.00 B)
 Download all attachments

2013-03-26 15:25:09

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH 2/2] pwm: tiehrpwm: Staticize non-exported symbols

On Tue, Mar 26, 2013 at 10:55:57PM +0800, Axel Lin wrote:
> Both ehrpwm_pwm_save_context() and ehrpwm_pwm_restore_context() are only used in
> this file, make them static.
>
> Signed-off-by: Axel Lin <[email protected]>

Applied, thanks.

Thierry

Attachments:
(No filename) (250.00 B)
 (No filename) (836.00 B)
 Download all attachments