2013-03-28 21:34:01

by Paul Bolle

[permalink] [raw]
Subject: [PATCH] [media] gspca: remove obsolete Kconfig macros

The et61x251 driver was removed in v3.5. Remove the last references to
its Kconfig macro now.

Signed-off-by: Paul Bolle <[email protected]>
---
Untested, as usual.

drivers/media/usb/gspca/etoms.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/media/usb/gspca/etoms.c b/drivers/media/usb/gspca/etoms.c
index 38f68e1..f165581 100644
--- a/drivers/media/usb/gspca/etoms.c
+++ b/drivers/media/usb/gspca/etoms.c
@@ -768,9 +768,7 @@ static const struct sd_desc sd_desc = {
/* -- module initialisation -- */
static const struct usb_device_id device_table[] = {
{USB_DEVICE(0x102c, 0x6151), .driver_info = SENSOR_PAS106},
-#if !defined CONFIG_USB_ET61X251 && !defined CONFIG_USB_ET61X251_MODULE
{USB_DEVICE(0x102c, 0x6251), .driver_info = SENSOR_TAS5130CXX},
-#endif
{}
};

--
1.7.11.7


2013-03-29 08:46:12

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] [media] gspca: remove obsolete Kconfig macros

Mauro,

Can you pick this one up? I don't have anything pending for gspca,
and to create a tree + pullreq for just a trivial patch is not really
efficient.

Alternatively I can put it on my TODO for when there is more gspca work,
esp. since there is not really a need to hurry with merging this.

Regards,

Hans


On 03/28/2013 10:33 PM, Paul Bolle wrote:
> The et61x251 driver was removed in v3.5. Remove the last references to
> its Kconfig macro now.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Untested, as usual.
>
> drivers/media/usb/gspca/etoms.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/usb/gspca/etoms.c b/drivers/media/usb/gspca/etoms.c
> index 38f68e1..f165581 100644
> --- a/drivers/media/usb/gspca/etoms.c
> +++ b/drivers/media/usb/gspca/etoms.c
> @@ -768,9 +768,7 @@ static const struct sd_desc sd_desc = {
> /* -- module initialisation -- */
> static const struct usb_device_id device_table[] = {
> {USB_DEVICE(0x102c, 0x6151), .driver_info = SENSOR_PAS106},
> -#if !defined CONFIG_USB_ET61X251 && !defined CONFIG_USB_ET61X251_MODULE
> {USB_DEVICE(0x102c, 0x6251), .driver_info = SENSOR_TAS5130CXX},
> -#endif
> {}
> };
>
>

2013-03-29 11:11:22

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH] [media] gspca: remove obsolete Kconfig macros

Em Fri, 29 Mar 2013 09:49:28 +0100
Hans de Goede <[email protected]> escreveu:

> Mauro,
>
> Can you pick this one up? I don't have anything pending for gspca,
> and to create a tree + pullreq for just a trivial patch is not really
> efficient.

No problem. I'll handle that.

Regards,
Mauro
> Alternatively I can put it on my TODO for when there is more gspca work,
> esp. since there is not really a need to hurry with merging this.
>
> Regards,
>
> Hans
>
>
> On 03/28/2013 10:33 PM, Paul Bolle wrote:
> > The et61x251 driver was removed in v3.5. Remove the last references to
> > its Kconfig macro now.
> >
> > Signed-off-by: Paul Bolle <[email protected]>
> > ---
> > Untested, as usual.
> >
> > drivers/media/usb/gspca/etoms.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/media/usb/gspca/etoms.c b/drivers/media/usb/gspca/etoms.c
> > index 38f68e1..f165581 100644
> > --- a/drivers/media/usb/gspca/etoms.c
> > +++ b/drivers/media/usb/gspca/etoms.c
> > @@ -768,9 +768,7 @@ static const struct sd_desc sd_desc = {
> > /* -- module initialisation -- */
> > static const struct usb_device_id device_table[] = {
> > {USB_DEVICE(0x102c, 0x6151), .driver_info = SENSOR_PAS106},
> > -#if !defined CONFIG_USB_ET61X251 && !defined CONFIG_USB_ET61X251_MODULE
> > {USB_DEVICE(0x102c, 0x6251), .driver_info = SENSOR_TAS5130CXX},
> > -#endif
> > {}
> > };
> >
> >


--

Cheers,
Mauro