2013-04-01 02:48:20

by Axel Lin

[permalink] [raw]
Subject: [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip

Signed-off-by: Axel Lin <[email protected]>
---
drivers/pwm/pwm-mxs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
index a53d309..23d5180 100644
--- a/drivers/pwm/pwm-mxs.c
+++ b/drivers/pwm/pwm-mxs.c
@@ -38,7 +38,6 @@

struct mxs_pwm_chip {
struct pwm_chip chip;
- struct device *dev;
struct clk *clk;
void __iomem *base;
};
@@ -166,7 +165,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)
return ret;
}

- mxs->dev = &pdev->dev;
platform_set_drvdata(pdev, mxs);

stmp_reset_block(mxs->base);
--
1.7.10.4



2013-04-01 02:49:31

by Axel Lin

[permalink] [raw]
Subject: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip

Signed-off-by: Axel Lin <[email protected]>
---
drivers/pwm/pwm-spear.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
index 3223b57..9563599 100644
--- a/drivers/pwm/pwm-spear.c
+++ b/drivers/pwm/pwm-spear.c
@@ -49,13 +49,11 @@
* @mmio_base: base address of pwm chip
* @clk: pointer to clk structure of pwm chip
* @chip: linux pwm chip representation
- * @dev: pointer to device structure of pwm chip
*/
struct spear_pwm_chip {
void __iomem *mmio_base;
struct clk *clk;
struct pwm_chip chip;
- struct device *dev;
};

static inline struct spear_pwm_chip *to_spear_pwm_chip(struct pwm_chip *chip)
@@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
if (IS_ERR(pc->clk))
return PTR_ERR(pc->clk);

- pc->dev = &pdev->dev;
platform_set_drvdata(pdev, pc);

pc->chip.dev = &pdev->dev;
--
1.7.10.4


2013-04-01 03:54:10

by Shiraz Hashim

[permalink] [raw]
Subject: Re: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip

Hi Axel,

Perhaps you meant pwm: spear: (instead of pwm: mxs) in the subject
line.

On Mon, Apr 01, 2013 at 10:49:25AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/pwm/pwm-spear.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 3223b57..9563599 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -49,13 +49,11 @@
> * @mmio_base: base address of pwm chip
> * @clk: pointer to clk structure of pwm chip
> * @chip: linux pwm chip representation
> - * @dev: pointer to device structure of pwm chip
> */
> struct spear_pwm_chip {
> void __iomem *mmio_base;
> struct clk *clk;
> struct pwm_chip chip;
> - struct device *dev;
> };
>
> static inline struct spear_pwm_chip *to_spear_pwm_chip(struct pwm_chip *chip)
> @@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(pc->clk))
> return PTR_ERR(pc->clk);
>
> - pc->dev = &pdev->dev;
> platform_set_drvdata(pdev, pc);
>
> pc->chip.dev = &pdev->dev;
> --
> 1.7.10.4


otherwise,
Acked-by: Shiraz Hashim <[email protected]>

2013-04-01 04:48:35

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip

On 1 April 2013 08:19, Axel Lin <[email protected]> wrote:

Apart from fixing subject you need to write something in logs too..

> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/pwm/pwm-spear.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
> index 3223b57..9563599 100644
> --- a/drivers/pwm/pwm-spear.c
> +++ b/drivers/pwm/pwm-spear.c
> @@ -49,13 +49,11 @@
> * @mmio_base: base address of pwm chip
> * @clk: pointer to clk structure of pwm chip
> * @chip: linux pwm chip representation
> - * @dev: pointer to device structure of pwm chip
> */
> struct spear_pwm_chip {
> void __iomem *mmio_base;
> struct clk *clk;
> struct pwm_chip chip;
> - struct device *dev;
> };
>
> static inline struct spear_pwm_chip *to_spear_pwm_chip(struct pwm_chip *chip)
> @@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)
> if (IS_ERR(pc->clk))
> return PTR_ERR(pc->clk);
>
> - pc->dev = &pdev->dev;
> platform_set_drvdata(pdev, pc);
>
> pc->chip.dev = &pdev->dev;

Acked-by: Viresh Kumar <[email protected]>

2013-04-01 06:55:49

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip

On Mon, Apr 01, 2013 at 10:48:13AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/pwm/pwm-mxs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-mxs.c b/drivers/pwm/pwm-mxs.c
> index a53d309..23d5180 100644
> --- a/drivers/pwm/pwm-mxs.c
> +++ b/drivers/pwm/pwm-mxs.c
> @@ -38,7 +38,6 @@
>
> struct mxs_pwm_chip {
> struct pwm_chip chip;
> - struct device *dev;
> struct clk *clk;
> void __iomem *base;
> };
> @@ -166,7 +165,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)
> return ret;
> }
>
> - mxs->dev = &pdev->dev;
> platform_set_drvdata(pdev, mxs);
>
> stmp_reset_block(mxs->base);
> --
> 1.7.10.4
>
>
>

2013-04-02 09:40:41

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH 1/2] pwm: mxs: Remove unused *dev from struct mxs_pwm_chip

On Mon, Apr 01, 2013 at 10:48:13AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/pwm/pwm-mxs.c | 2 --
> 1 file changed, 2 deletions(-)

Both patches applied, thanks.

Thierry

Attachments:
(No filename) (221.00 B)
 (No filename) (836.00 B)
 Download all attachments