The logic to check return value of clk_enable() and clk_prepare() is reversed,
fix it.
Signed-off-by: Axel Lin <[email protected]>
Cc: <[email protected]>
---
This is v3 of "pwm: spear: Fix enable pwm output".
I change the subject line because it also fixes checking return value of
clk_prepare().
Also add cc stable.
Axel
drivers/pwm/pwm-spear.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c
index 69a2d9e..3223b57 100644
--- a/drivers/pwm/pwm-spear.c
+++ b/drivers/pwm/pwm-spear.c
@@ -143,7 +143,7 @@ static int spear_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
u32 val;
rc = clk_enable(pc->clk);
- if (!rc)
+ if (rc)
return rc;
val = spear_pwm_readl(pc, pwm->hwpwm, PWMCR);
@@ -209,12 +209,12 @@ static int spear_pwm_probe(struct platform_device *pdev)
pc->chip.npwm = NUM_PWM;
ret = clk_prepare(pc->clk);
- if (!ret)
+ if (ret)
return ret;
if (of_device_is_compatible(np, "st,spear1340-pwm")) {
ret = clk_enable(pc->clk);
- if (!ret) {
+ if (ret) {
clk_unprepare(pc->clk);
return ret;
}
--
1.7.10.4
On 30 March 2013 18:13, Axel Lin <[email protected]> wrote:
> The logic to check return value of clk_enable() and clk_prepare() is reversed,
> fix it.
>
> Signed-off-by: Axel Lin <[email protected]>
> Cc: <[email protected]>
> ---
> This is v3 of "pwm: spear: Fix enable pwm output".
> I change the subject line because it also fixes checking return value of
> clk_prepare().
> Also add cc stable.
>
> Axel
>
> drivers/pwm/pwm-spear.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Sorry for the delays caused due to me.
Acked-by: Viresh Kumar <[email protected]>
>
> Sorry for the delays caused due to me.
>
> Acked-by: Viresh Kumar <[email protected]>
Actually, I'm really appreciate having your review.
Thanks,
Axel
On Sat, Mar 30, 2013 at 08:43:22PM +0800, Axel Lin wrote:
> The logic to check return value of clk_enable() and clk_prepare() is reversed,
> fix it.
>
> Signed-off-by: Axel Lin <[email protected]>
> Cc: <[email protected]>
> ---
> This is v3 of "pwm: spear: Fix enable pwm output".
> I change the subject line because it also fixes checking return value of
> clk_prepare().
> Also add cc stable.
Applied, thanks.
Thierry