2013-03-31 15:07:37

by Axel Lin

[permalink] [raw]
Subject: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails

Return proper error instead of 0 if twl6030_pwm_enable() fails.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/pwm/pwm-twl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
index ee7fa5d..2782001 100644
--- a/drivers/pwm/pwm-twl.c
+++ b/drivers/pwm/pwm-twl.c
@@ -248,7 +248,7 @@ static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
twl->twl6030_toggle3 = val;
out:
mutex_unlock(&twl->mutex);
- return 0;
+ return ret;
}

static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
--
1.7.10.4



2013-04-02 07:15:00

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails

On 03/31/2013 05:07 PM, Axel Lin wrote:
> Return proper error instead of 0 if twl6030_pwm_enable() fails.
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Peter Ujfalusi <[email protected]>

> ---
> drivers/pwm/pwm-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
> index ee7fa5d..2782001 100644
> --- a/drivers/pwm/pwm-twl.c
> +++ b/drivers/pwm/pwm-twl.c
> @@ -248,7 +248,7 @@ static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> twl->twl6030_toggle3 = val;
> out:
> mutex_unlock(&twl->mutex);
> - return 0;
> + return ret;
> }
>
> static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
>


--
P?ter

2013-04-02 09:41:08

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] pwm: twl: Return proper error if twl6030_pwm_enable() fails

On Sun, Mar 31, 2013 at 11:07:30PM +0800, Axel Lin wrote:
> Return proper error instead of 0 if twl6030_pwm_enable() fails.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/pwm/pwm-twl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry

Attachments:
(No filename) (292.00 B)
 (No filename) (836.00 B)
 Download all attachments