2013-03-13 09:46:11

by Sachin Kamat

Subject: [PATCH 1/1] irqchip: irq-gic: Fix checkpatch errors

Fixes the following errors:
ERROR: do not initialise statics to 0 or NULL
ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Sachin Kamat <[email protected]>
---
Compile tested and based on linux-next tree (20130313).
---
drivers/irqchip/irq-gic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index a32e0d5..d06d5a4 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -127,7 +127,7 @@ static inline void gic_set_base_accessor(struct gic_chip_data *data,
#else
#define gic_data_dist_base(d) ((d)->dist_base.common_base)
#define gic_data_cpu_base(d) ((d)->cpu_base.common_base)
-#define gic_set_base_accessor(d,f)
+#define gic_set_base_accessor(d, f)
#endif

static inline void __iomem *gic_dist_base(struct irq_data *d)
@@ -807,7 +807,7 @@ void __cpuinit gic_secondary_init(unsigned int gic_nr)
}

#ifdef CONFIG_OF
-static int gic_cnt __initdata = 0;
+static int gic_cnt __initdata;

int __init gic_of_init(struct device_node *node, struct device_node *parent)
{
--
1.7.4.1

2013-04-02 16:40:46

by Olof Johansson

Subject: Re: [PATCH 1/1] irqchip: irq-gic: Fix checkpatch errors

On Wed, Mar 13, 2013 at 03:05:15PM +0530, Sachin Kamat wrote:
> Fixes the following errors:
> ERROR: do not initialise statics to 0 or NULL
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> Compile tested and based on linux-next tree (20130313).

I haven't seen this show up in linux-next through Thomas, so I've applied it to
our next/cleanup branch.

Thanks.


-Olof

2013-04-03 03:32:12

by Sachin Kamat

Subject: Re: [PATCH 1/1] irqchip: irq-gic: Fix checkpatch errors

On 2 April 2013 22:10, Olof Johansson <[email protected]> wrote:
> On Wed, Mar 13, 2013 at 03:05:15PM +0530, Sachin Kamat wrote:
>> Fixes the following errors:
>> ERROR: do not initialise statics to 0 or NULL
>> ERROR: space required after that ',' (ctx:VxV)
>>
>> Signed-off-by: Sachin Kamat <[email protected]>
>> ---
>> Compile tested and based on linux-next tree (20130313).
>
> I haven't seen this show up in linux-next through Thomas, so I've applied it to
> our next/cleanup branch.

Thanks Olof.
Would you also be taking the patch at [1] as I havent heard back on
that one too.
Please let me know if you want me to resend this one as I had not
marked you in CC earlier.

[1] https://lkml.org/lkml/2013/3/13/107

--
With warm regards,
Sachin