2013-04-03 22:05:26

by Axel Lin

[permalink] [raw]
Subject: [PATCH] regulator: ab8500: Remove ab8500_regulator_set_voltage_time_sel

All users of ab8500_regulator_volt_mode_ops and ab8500_regulator_volt_ops
do not set info->desc.enable_time, thus set_voltage_time_sel() always returns 0.
Remove it.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/ab8500.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index a8552a5..517305e 100644
--- a/drivers/regulator/ab8500.c
+++ b/drivers/regulator/ab8500.c
@@ -648,15 +648,6 @@ static int ab8540_aux3_regulator_set_voltage_sel(struct regulator_dev *rdev,
return ret;
}

-static int ab8500_regulator_set_voltage_time_sel(struct regulator_dev *rdev,
- unsigned int old_sel,
- unsigned int new_sel)
-{
- struct ab8500_regulator_info *info = rdev_get_drvdata(rdev);
-
- return info->desc.enable_time;
-}
-
static struct regulator_ops ab8500_regulator_volt_mode_ops = {
.enable = ab8500_regulator_enable,
.disable = ab8500_regulator_disable,
@@ -679,7 +670,6 @@ static struct regulator_ops ab8540_aux3_regulator_volt_mode_ops = {
.get_voltage_sel = ab8540_aux3_regulator_get_voltage_sel,
.set_voltage_sel = ab8540_aux3_regulator_set_voltage_sel,
.list_voltage = regulator_list_voltage_table,
- .set_voltage_time_sel = ab8500_regulator_set_voltage_time_sel,
};

static struct regulator_ops ab8500_regulator_volt_ops = {
@@ -689,7 +679,6 @@ static struct regulator_ops ab8500_regulator_volt_ops = {
.get_voltage_sel = ab8500_regulator_get_voltage_sel,
.set_voltage_sel = ab8500_regulator_set_voltage_sel,
.list_voltage = regulator_list_voltage_table,
- .set_voltage_time_sel = ab8500_regulator_set_voltage_time_sel,
};

static struct regulator_ops ab8500_regulator_mode_ops = {
--
1.7.10.4



2013-04-05 10:23:51

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: ab8500: Remove ab8500_regulator_set_voltage_time_sel

On Thu, Apr 04, 2013 at 06:05:17AM +0800, Axel Lin wrote:
> All users of ab8500_regulator_volt_mode_ops and ab8500_regulator_volt_ops
> do not set info->desc.enable_time, thus set_voltage_time_sel() always returns 0.
> Remove it.

Applied, thanks.


Attachments:
(No filename) (248.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments